From 696ea0d2f4fdaa17db929e152edba19bf7666d84 Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Fri, 4 Aug 2023 14:22:59 +0200 Subject: pkg/report: drop "ALT: KMSAN origin" titles for uninit reports It was initially proposed in https://github.com/google/syzkaller/issues/1575 that KMSAN reports with the same origin should be clustered together using an alt title. This however turns out to be too aggressive: certain KMSAN reports have their uninitialized values originating from common functions - this leads to too many KMSAN reports being glued together. Because KMSAN reports can be also clustered with KASAN reports or other kernel panics, ultimately seemingly unrelated crashes are considered similar just because they share their top frames with two KMSAN reports that, in turn, share the same origin. The resulting issues on the dashboard look confusing to the users, they are hard to find and require manual untangling, which probably outweighs the benefits of having KMSAN issues with exactly the same origin clustered together. For other types of KMSAN reports (infoleaks and use-after-frees) the alt titles are preserved. First, there are fewer of those on the dashboard. Second, they are rarely grouped together with non-KASAN reports and are less likely to cause a lot of mess. --- pkg/report/linux.go | 1 - 1 file changed, 1 deletion(-) (limited to 'pkg/report/linux.go') diff --git a/pkg/report/linux.go b/pkg/report/linux.go index fd63bf7e4..9629e0dea 100644 --- a/pkg/report/linux.go +++ b/pkg/report/linux.go @@ -1374,7 +1374,6 @@ var linuxOopses = append([]*oops{ fmt: "KMSAN: %[1]v in %[3]v", alt: []string{ "bad-access in %[3]v", - "KMSAN origin in %[4]v", }, stack: &stackFmt{ parts: []*regexp.Regexp{ -- cgit mrf-deployment