From 11414272b7f8f8fb98d7084178e20699b6f2d759 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Fri, 19 Sep 2025 14:27:43 +0200 Subject: pkg/manager: reduce time spend under mutex We don't need it to hold it for the call to the externally supplied callback. --- pkg/manager/diff.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'pkg/manager/diff.go') diff --git a/pkg/manager/diff.go b/pkg/manager/diff.go index b6423e4c9..44bd6a225 100644 --- a/pkg/manager/diff.go +++ b/pkg/manager/diff.go @@ -378,18 +378,14 @@ func (dc *diffContext) NeedRepro(crash *Crash) bool { if !needReproForTitle(crash.Title) { return false } - dc.mu.Lock() - defer dc.mu.Unlock() - ctx, cancel := context.WithTimeout(context.Background(), time.Minute) defer cancel() if dc.ignoreCrash(ctx, crash.Title) { return false } - if dc.reproAttempts[crash.Title] > maxReproAttempts { - return false - } - return true + dc.mu.Lock() + defer dc.mu.Unlock() + return dc.reproAttempts[crash.Title] <= maxReproAttempts } func (dc *diffContext) RunRepro(ctx context.Context, crash *Crash) *ReproResult { -- cgit mrf-deployment