From ad097c94a04025c865b3956566ea5da7670ed437 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 21 Dec 2021 14:23:50 +0100 Subject: pkg/testutil: add package Add package with RaceEnabled const that can be used in test to skip long tests in race mode. Switch existing tests to use the new package. Update #2886 --- pkg/csource/csource_test.go | 14 ++++++++++++++ pkg/csource/race_test.go | 24 ------------------------ 2 files changed, 14 insertions(+), 24 deletions(-) delete mode 100644 pkg/csource/race_test.go (limited to 'pkg/csource') diff --git a/pkg/csource/csource_test.go b/pkg/csource/csource_test.go index fc3b21573..91bd2cccf 100644 --- a/pkg/csource/csource_test.go +++ b/pkg/csource/csource_test.go @@ -14,11 +14,25 @@ import ( "testing" "time" + "github.com/google/syzkaller/pkg/testutil" "github.com/google/syzkaller/prog" _ "github.com/google/syzkaller/sys" "github.com/google/syzkaller/sys/targets" ) +func init() { + // csource tests consume too much memory under race detector (>1GB), + // and periodically timeout on Travis. So we skip them. + if testutil.RaceEnabled { + for _, arg := range os.Args[1:] { + if strings.Contains(arg, "-test.short") { + fmt.Printf("skipping race testing in short mode\n") + os.Exit(0) + } + } + } +} + func TestGenerate(t *testing.T) { t.Parallel() checked := make(map[string]bool) diff --git a/pkg/csource/race_test.go b/pkg/csource/race_test.go deleted file mode 100644 index c41cef5d3..000000000 --- a/pkg/csource/race_test.go +++ /dev/null @@ -1,24 +0,0 @@ -// Copyright 2018 syzkaller project authors. All rights reserved. -// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file. - -//go:build race -// +build race - -package csource - -import ( - "fmt" - "os" - "strings" -) - -func init() { - // csource tests consume too much memory under race detector (>1GB), - // and periodically timeout on Travis. So we skip them. - for _, arg := range os.Args[1:] { - if strings.Contains(arg, "-test.short") { - fmt.Printf("skipping race testing in short mode\n") - os.Exit(0) - } - } -} -- cgit mrf-deployment