From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- pkg/csource/options_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'pkg/csource/options_test.go') diff --git a/pkg/csource/options_test.go b/pkg/csource/options_test.go index 1c403ae06..43cffd1d5 100644 --- a/pkg/csource/options_test.go +++ b/pkg/csource/options_test.go @@ -7,10 +7,12 @@ import ( "fmt" "reflect" "testing" + + "github.com/google/syzkaller/sys/targets" ) func TestParseOptions(t *testing.T) { - for _, opts := range allOptionsSingle("linux") { + for _, opts := range allOptionsSingle(targets.Linux) { data := opts.Serialize() got, err := DeserializeOptions(data) if err != nil { -- cgit mrf-deployment