From 179f40292f64debb6b3ea2fe5e950f62f5a05a18 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Mon, 16 Sep 2024 14:29:26 +0200 Subject: pkg/validator: target value is not empty by default The consistency make the code more predictable. We want all the values to be non-empty. If "empty" is an option - use validator.AnyOk(validator.EmptyStr(target), otherCheck(target)). --- pkg/covermerger/bq_csv_reader.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/covermerger/bq_csv_reader.go') diff --git a/pkg/covermerger/bq_csv_reader.go b/pkg/covermerger/bq_csv_reader.go index 60f6e5829..187da1812 100644 --- a/pkg/covermerger/bq_csv_reader.go +++ b/pkg/covermerger/bq_csv_reader.go @@ -34,7 +34,7 @@ func MakeBQCSVReader() *bqCSVReader { func (r *bqCSVReader) InitNsRecords(ctx context.Context, ns, filePath, commit string, from, to civil.Date) error { if err := validator.AnyError("input validation failed", validator.NamespaceName(ns), - validator.KernelFilePath(filePath), + validator.AnyOk(validator.EmptyStr(filePath), validator.KernelFilePath(filePath)), validator.AnyOk(validator.EmptyStr(commit), validator.CommitHash(commit)), ); err != nil { return err -- cgit mrf-deployment