From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- pkg/compiler/consts_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'pkg/compiler/consts_test.go') diff --git a/pkg/compiler/consts_test.go b/pkg/compiler/consts_test.go index 77a124b04..685525bc9 100644 --- a/pkg/compiler/consts_test.go +++ b/pkg/compiler/consts_test.go @@ -23,7 +23,7 @@ func TestExtractConsts(t *testing.T) { if desc == nil { t.Fatalf("failed to parse input") } - target := targets.List["linux"]["amd64"] + target := targets.List[targets.Linux][targets.AMD64] fileInfo := ExtractConsts(desc, target, func(pos ast.Pos, msg string) { t.Fatalf("%v: %v", pos, msg) }) @@ -69,7 +69,7 @@ func TestConstErrors(t *testing.T) { em.DumpErrors() t.Fatalf("parsing failed") } - target := targets.List["linux"]["amd64"] + target := targets.List[targets.Linux][targets.AMD64] ExtractConsts(desc, target, em.ErrorHandler) em.Check() } -- cgit mrf-deployment