From 9633c5c8a1a030cdfdc0f94ae460314c7fc15faa Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 29 Mar 2019 11:00:34 +0100 Subject: pkg/build: extract bazel build errors We currently manually call extractRootCause in few selected places to denote kernel build errors that we want to report to developers. The rest are considered infra errors that we don't report. This does not work well. We are missing fuchsia and gvisor build errors. Treat all external command exection failures as kernel build errors instead. Let's see how this works in practice. Also add bazel-specfic error patterns and tests. --- pkg/build/linux.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/build/linux.go') diff --git a/pkg/build/linux.go b/pkg/build/linux.go index 8b57cbec4..bdfa0edd2 100644 --- a/pkg/build/linux.go +++ b/pkg/build/linux.go @@ -66,7 +66,7 @@ func (linux) buildKernel(kernelDir, outputDir, compiler string, config []byte) e } cmd.Dir = kernelDir if _, err := osutil.Run(time.Hour, cmd); err != nil { - return extractRootCause(err) + return err } vmlinux := filepath.Join(kernelDir, "vmlinux") outputVmlinux := filepath.Join(outputDir, "obj", "vmlinux") -- cgit mrf-deployment