From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- pkg/build/fuchsia.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/build/fuchsia.go') diff --git a/pkg/build/fuchsia.go b/pkg/build/fuchsia.go index f4bb2c8b4..ea1e2dccb 100644 --- a/pkg/build/fuchsia.go +++ b/pkg/build/fuchsia.go @@ -33,7 +33,7 @@ func (fu fuchsia) build(params *Params) error { return err } - sysTarget := targets.Get("fuchsia", params.TargetArch) + sysTarget := targets.Get(targets.Fuchsia, params.TargetArch) if sysTarget == nil { return fmt.Errorf("unsupported fuchsia arch %v", params.TargetArch) } -- cgit mrf-deployment