From be47ebb0eb17e47c9f1f84156e17aa6970d47435 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 17 May 2018 17:18:24 +0200 Subject: pkg/kernel: allow to split full make output Currently kernel build failures are insanely verbose (contain full kernel build output) and there is no way to separate short descriptions from full output. Make it possible. Also try to extract failure root cause froom build log. Use this in pkg/bisect to not pollute log on build failures. Update #501 --- pkg/bisect/bisect.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'pkg/bisect') diff --git a/pkg/bisect/bisect.go b/pkg/bisect/bisect.go index 5fce43ced..f2770d6ce 100644 --- a/pkg/bisect/bisect.go +++ b/pkg/bisect/bisect.go @@ -227,7 +227,12 @@ func (env *env) test() (git.BisectResult, error) { cfg.Kernel.Cmdline, cfg.Kernel.Sysctl, cfg.Kernel.Config) env.buildTime += time.Since(buildStart) if err != nil { - env.log("kernel build failed: %v", err) + if verr, ok := err.(*osutil.VerboseError); ok { + env.log("%v", verr.Title) + env.saveDebugFile(current.Hash, 0, verr.Output) + } else { + env.log("%v", err) + } return git.BisectSkip, nil } testStart := time.Now() -- cgit mrf-deployment