From 8f58e4babeecd6606f4c9729919cc85c470bc422 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Sat, 17 Oct 2020 20:00:45 +0200 Subject: pkg/bisect: switch to kconfig.Minimize Use the new kconfig.Minimize for config minization instead of the config-bisect.pl script. This is mostly just deleting code. Also update tests: - minimization is now supposed to test the baseline config (update "testos" stub accordingly) - minimization is not supposed to return a config that does not build (a reasonable config minimization procedure can't arrive to such config), remove test that tests this Update #2171 --- pkg/bisect/bisect_test.go | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'pkg/bisect/bisect_test.go') diff --git a/pkg/bisect/bisect_test.go b/pkg/bisect/bisect_test.go index 3bbc2e2ea..c21548a4d 100644 --- a/pkg/bisect/bisect_test.go +++ b/pkg/bisect/bisect_test.go @@ -41,7 +41,7 @@ func (env *testEnv) BuildKernel(compilerBin, cCache, userspaceDir, cmdlineFile, kernelSign = "same-sign-" + configHash } env.config = string(kernelConfig) - if env.config == "baseline-fails" || env.config == "broken-build" { + if env.config == "baseline-fails" { return "", kernelSign, fmt.Errorf("failure") } return "", kernelSign, nil @@ -184,15 +184,6 @@ var bisectionTests = []BisectionTest{ baselineConfig: "baseline-repro", resultingConfig: "baseline-repro", }, - { - name: "cause-finds-cause-baseline-broken-build", - startCommit: 905, - commitLen: 1, - expectRep: true, - culprit: 602, - baselineConfig: "baseline-broken-build", - resultingConfig: "original config", - }, { name: "cause-finds-cause-baseline-does-not-repro", startCommit: 905, -- cgit mrf-deployment