From 5142e5aa3b3f41019136f156bc9ece61c0a17f42 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 6 Jul 2023 19:41:38 +0200 Subject: pkg/bisect: fix SYZFATAL bisections After the previous change, pkg/bisect is unable to bisect SYZFATAL errors. Fix the bug in the logic and add a test. --- pkg/bisect/bisect.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'pkg/bisect/bisect.go') diff --git a/pkg/bisect/bisect.go b/pkg/bisect/bisect.go index 9668144ef..3044ae081 100644 --- a/pkg/bisect/bisect.go +++ b/pkg/bisect/bisect.go @@ -803,7 +803,8 @@ func (env *env) isTransientError(rep *report.Report) bool { for _, t := range env.reportTypes { hadSyzFailure = hadSyzFailure || t == crash.SyzFailure } - return rep.Type == crash.SyzFailure && !hadSyzFailure + return rep.Type == crash.SyzFailure && + len(env.reportTypes) > 0 && !hadSyzFailure } func (env *env) saveDebugFile(hash string, idx int, data []byte) { -- cgit mrf-deployment