From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- pkg/ast/parser_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'pkg/ast') diff --git a/pkg/ast/parser_test.go b/pkg/ast/parser_test.go index b5861b5a8..d3a9049bc 100644 --- a/pkg/ast/parser_test.go +++ b/pkg/ast/parser_test.go @@ -10,10 +10,12 @@ import ( "reflect" "strings" "testing" + + "github.com/google/syzkaller/sys/targets" ) func TestParseAll(t *testing.T) { - files, err := filepath.Glob(filepath.Join("..", "..", "sys", "linux", "*.txt")) + files, err := filepath.Glob(filepath.Join("..", "..", "sys", targets.Linux, "*.txt")) if err != nil || len(files) == 0 { t.Fatalf("failed to read sys dir: %v", err) } -- cgit mrf-deployment