From 71ad32b1e95a1c1dfca8e6ca4a530b77afcc4974 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 27 Jan 2026 08:57:52 +0100 Subject: pkg/aflow/flow/patching: harden against empty generated patches Make codeeditor error on nop changes that don't actually change the code. Make patch testing error on empty patch. Perhaps we need a notion of "mandatory" tools that must be called successfully at least once... not sure yet. --- pkg/aflow/tool/codeeditor/codeeditor_test.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'pkg/aflow/tool/codeeditor/codeeditor_test.go') diff --git a/pkg/aflow/tool/codeeditor/codeeditor_test.go b/pkg/aflow/tool/codeeditor/codeeditor_test.go index 06a97d7af..0b066e3b5 100644 --- a/pkg/aflow/tool/codeeditor/codeeditor_test.go +++ b/pkg/aflow/tool/codeeditor/codeeditor_test.go @@ -105,6 +105,25 @@ foo`) ) } +func TestCodeeditorNopEdit(t *testing.T) { + dir := writeTestFile(t, "src.c", ` +line0 +line1 +`) + aflow.TestTool(t, Tool, + state{ + KernelScratchSrc: dir, + }, + args{ + SourceFile: "src.c", + CurrentCode: " line0", + NewCode: "line0", + }, + struct{}{}, + `The edit does not change the code.`, + ) +} + func TestCodeeditorReplacement(t *testing.T) { type Test struct { curFile string -- cgit mrf-deployment