From e09601ff0fad36b90ec8539f5e3d0fcfc615d42d Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 11 Mar 2026 05:56:50 +0100 Subject: syz-agent: systematically show verbose error messages Currently we added custom code to kernel build action, and few others to expose verbose errors from executed binaries (notably make). But lots of other binary executions missing this logic, e.g. for git failure we currently see unuseful: failed to run ["git" "fetch" "--force" "--tags" exit status 128 Instead of adding more and more custom code to do the same, remove the custom code and always add verbose output in syz-agent and tools/syz-aflow. --- pkg/aflow/flow/patching/actions.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'pkg/aflow/flow/patching') diff --git a/pkg/aflow/flow/patching/actions.go b/pkg/aflow/flow/patching/actions.go index bea70e978..aced1fbe3 100644 --- a/pkg/aflow/flow/patching/actions.go +++ b/pkg/aflow/flow/patching/actions.go @@ -5,7 +5,6 @@ package patching import ( "errors" - "fmt" "os/exec" "path/filepath" "strings" @@ -137,7 +136,7 @@ func recentCommits(ctx *aflow.Context, args recentCommitsArgs) (recentCommitsRes gitArgs := append([]string{"log", "--format=%s", "--no-merges", "-n", "20", args.KernelCommit}, files...) output, err := osutil.RunCmd(10*time.Minute, kernelRepoDir, "git", gitArgs...) if err != nil { - return aflow.FlowError(fmt.Errorf("%w\n%s", err, output)) + return aflow.FlowError(err) } res.RecentCommits = string(output) return nil -- cgit mrf-deployment