From af2638df2c9e396d35a593598d4d30a078d855e7 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 21 Oct 2024 11:53:41 +0200 Subject: executor: don't kill executor exec process group Killing a process group (negative pid) only makes sense when the process is a group leader (called setsid/setpgrp/setpgid). Executor exec process is not a group leader, so don't try to kill its group. For our controlled executor subprocesses we rely on PR_SET_PDEATHSIG for reliable killing of all child subprocesses. --- executor/subprocess.h | 1 - 1 file changed, 1 deletion(-) (limited to 'executor') diff --git a/executor/subprocess.h b/executor/subprocess.h index 2553422a9..5e638c1f5 100644 --- a/executor/subprocess.h +++ b/executor/subprocess.h @@ -76,7 +76,6 @@ public: { if (!pid_) fail("subprocess hasn't started or already waited"); - kill(-pid_, SIGKILL); kill(pid_, SIGKILL); int pid = 0; int wstatus = 0; -- cgit mrf-deployment