From 07dedd50ee8834dbca4da7667e69e72b7d0565b9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 27 Jun 2024 12:01:58 +0200 Subject: pkg/fuzzer: remove signal rotation Signal rotation is intended to make the fuzzer re-discover flaky coverage in non flaky way. However, taking into accout that we get effectively the same effect after each manager restart, and that the fuzzer is overloaded with triage/smash jobs, it does not look to be worth it. --- executor/cover_filter.h | 6 ------ executor/executor_runner.h | 4 +--- executor/test.h | 7 ------- 3 files changed, 1 insertion(+), 16 deletions(-) (limited to 'executor') diff --git a/executor/cover_filter.h b/executor/cover_filter.h index c303d8b23..d0a7be2d7 100644 --- a/executor/cover_filter.h +++ b/executor/cover_filter.h @@ -44,12 +44,6 @@ public: byte |= bit; } - void Remove(uint64 pc) - { - auto [byte, bit] = FindByte(pc, true); - byte &= ~bit; - } - bool Contains(uint64 pc) { auto [byte, bit] = FindByte(pc, false); diff --git a/executor/executor_runner.h b/executor/executor_runner.h index 86ce1819a..992227787 100644 --- a/executor/executor_runner.h +++ b/executor/executor_runner.h @@ -636,13 +636,11 @@ private: void Handle(const rpc::SignalUpdateRawT& msg) { - debug("recv signal update: new=%zu drop=%zu\n", msg.new_max.size(), msg.drop_max.size()); + debug("recv signal update: new=%zu\n", msg.new_max.size()); if (!max_signal_) fail("signal update when no signal filter installed"); for (auto pc : msg.new_max) max_signal_->Insert(pc); - for (auto pc : msg.drop_max) - max_signal_->Remove(pc); } void Handle(const rpc::CorpusTriagedRawT& msg) diff --git a/executor/test.h b/executor/test.h index e6fabf63f..1ca3c6f26 100644 --- a/executor/test.h +++ b/executor/test.h @@ -269,13 +269,6 @@ static int test_cover_filter() ret = 1; } } - - filter.Remove(105); - if (filter.Contains(104) || filter.Contains(105) || filter.Contains(111)) - printf("filter contains 105 after removal\n"); - if (!filter.Contains(103)) - printf("filter doesn't contains 103 after 105 removal\n"); - return ret; } -- cgit mrf-deployment