From a659b3f1dc889d5ab5ead017b877765b3d042379 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Sun, 21 Feb 2021 12:32:11 +0100 Subject: pkg/report: detect executor failures Currently all executor fail errors go into "lost connection" bucket. This is not very useful. First, there are different executor failures. Second, it's not possible to understand what failures happen how frequently. Third, there are not authentic lost connection. Create separate SYZFAIL: bugs for them. Update #573 Update #502 Update #318 --- executor/android/android_seccomp.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'executor/android') diff --git a/executor/android/android_seccomp.h b/executor/android/android_seccomp.h index d8df52792..f3febac2c 100644 --- a/executor/android/android_seccomp.h +++ b/executor/android/android_seccomp.h @@ -46,7 +46,7 @@ typedef struct Filter_t { static void push_back(Filter* filter_array, struct sock_filter filter) { if (filter_array->count == kFilterMaxSize) - fail("can't add another syscall to seccomp filter: count %zu", filter_array->count); + failmsg("can't add another syscall to seccomp filter", "count=%zu", filter_array->count); filter_array->data[filter_array->count++] = filter; } @@ -79,9 +79,8 @@ static void install_filter(const Filter* f) (struct sock_filter*)&f->data[0], }; // This assumes either the current process has CAP_SYS_ADMIN, or PR_SET_NO_NEW_PRIVS bit is set. - if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog) < 0) { - fail("Could not set seccomp filter of size %zu", f->count); - } + if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog) < 0) + failmsg("could not set seccomp filter", "size=%zu", f->count); } // Modified from the orignal Android code as we don't need dual arch support -- cgit mrf-deployment