From d25487bc2e50dbb3ec89a390467d1100744cac63 Mon Sep 17 00:00:00 2001 From: Marco Vanotti Date: Wed, 6 Feb 2019 04:33:35 -0800 Subject: sys/fuchsia: fix fidlgen issues * sys/fuchsia: fix fidlgen issues. This change modifies fidlgen removing fuchsia.mediacodec and renaming zircon-ethernet to fuchsia-hardware-ethernet. fuchsia.mediacodec has most of its functionality merged into fuchsia.media and it's not included in the default amd64 builds. zircon-ethernet has been renamed to fuchsia-hardware-ethernet recently: https://fuchsia-review.googlesource.com/c/zircon/+/237178 * docs/fuchsia: Add troubleshooting sections This commit adds a troubleshooting section in the fuchsia syzkaller docs that mentions how to solve fidlgen issues when fidl interfaces are removed or renamed. * sys/fuchsia: remove stale autogenerated files. * sys/fucsia run make extract && make generate. --- docs/fuchsia.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'docs') diff --git a/docs/fuchsia.md b/docs/fuchsia.md index c37e0f5fd..dd5243f91 100644 --- a/docs/fuchsia.md +++ b/docs/fuchsia.md @@ -113,3 +113,22 @@ Run `syz-ci` as: ``` SOURCEDIR=/bootstrap/fuchsia ./syz-ci -config ci.cfg ``` + +## Troubleshooting + +While running the `make extract` step, it's possible that the fidl definitions +are not up to date. It could happen that they have been removed or renamed. + +If this is the case, you would see an error mentioning that the fidl.json file +could not be found: + +``` +go generate ./sys/fuchsia +cannot find /path-to-fuchsia/out/x64/fidling/gen/zircon/public/fidl/zircon-ethernet/zircon-ethernet.fidl.json +exit status 1 +``` + +You can search for the string in the fuchsia repos or in the code-review tool to +see what happened to it. If the fidl interface was renamed or removed, you +should update `sys/fuchsia/fidlgen/main.go` to reflect this change, and remove the +stale autogenerated files. -- cgit mrf-deployment