From dbf22f580b33e27b4f567b36ed52351cb0fc8d22 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 19 Feb 2021 19:56:01 +0100 Subject: dashboard/app: remove restriction on max log size This restriction was meant or emails. But now we don't embed log in emails, they are provided as dashboard links. Now this only affects external reporting, which can handle large logs itself. On the other hand, external reporting does not have a way to "restore" full log. Remove the restriction. --- dashboard/app/jobs.go | 3 --- dashboard/app/reporting.go | 4 ---- 2 files changed, 7 deletions(-) (limited to 'dashboard') diff --git a/dashboard/app/jobs.go b/dashboard/app/jobs.go index 938444b89..7b31623bb 100644 --- a/dashboard/app/jobs.go +++ b/dashboard/app/jobs.go @@ -629,9 +629,6 @@ func createBugReportForJob(c context.Context, job *Job, jobKey *db.Key, config i if err != nil { return nil, err } - if len(crashLog) > maxMailLogLen { - crashLog = crashLog[len(crashLog)-maxMailLogLen:] - } report, _, err := getText(c, textCrashReport, job.CrashReport) if err != nil { return nil, err diff --git a/dashboard/app/reporting.go b/dashboard/app/reporting.go index 0b6e5083a..d4573559d 100644 --- a/dashboard/app/reporting.go +++ b/dashboard/app/reporting.go @@ -27,7 +27,6 @@ import ( // - incomingCommand is called by backends to update bug statuses. const ( - maxMailLogLen = 1 << 20 maxMailReportLen = 64 << 10 maxInlineError = 16 << 10 notifyResendPeriod = 14 * 24 * time.Hour @@ -391,9 +390,6 @@ func createBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key if err != nil { return nil, err } - if len(crashLog) > maxMailLogLen { - crashLog = crashLog[len(crashLog)-maxMailLogLen:] - } report, _, err := getText(c, textCrashReport, crash.Report) if err != nil { return nil, err -- cgit mrf-deployment