From 9e70464425eebd2fa590c49a04f09e407d4bc3d4 Mon Sep 17 00:00:00 2001
From: Jeongjun Park <aha310510@gmail.com>
Date: Sun, 27 Apr 2025 19:34:10 +0900
Subject: dashboard/app/templates: fix incorrect use of *Sort function

We are using incorrect *Sort functions when using some sortTable functions.
Also, this is causing the current syz repro sort to not work.

Thereforce we need to modify it to use the correct *Sort functions
and remove unnecessary tab spaces to pass the intended text to
the *Sort functions.
---
 dashboard/app/templates/templates.html | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

(limited to 'dashboard')

diff --git a/dashboard/app/templates/templates.html b/dashboard/app/templates/templates.html
index 571e262cd..66db3a4e6 100644
--- a/dashboard/app/templates/templates.html
+++ b/dashboard/app/templates/templates.html
@@ -433,8 +433,8 @@ Use of this source code is governed by Apache 2 LICENSE that can be found in the
 			<th><a onclick="return sortTable(this, 'Syzkaller', textSort)" href="#">Syzkaller</a></th>
 			<th><a onclick="return sortTable(this, 'Config', textSort)" href="#">Config</a></th>
 			<th><a onclick="return sortTable(this, 'Log', textSort)" href="#">Log</a></th>
-			<th><a onclick="return sortTable(this, 'Report', reproSort)" href="#">Report</a></th>
-			<th><a onclick="return sortTable(this, 'Syz repro', reproSort)" href="#">Syz repro</a></th>
+			<th><a onclick="return sortTable(this, 'Report', textSort)" href="#">Report</a></th>
+			<th><a onclick="return sortTable(this, 'Syz repro', textSort)" href="#">Syz repro</a></th>
 			<th><a onclick="return sortTable(this, 'C repro', textSort)" href="#">C repro</a></th>
 			<th><a onclick="return sortTable(this, 'VM info', textSort)" href="#">VM info</a></th>
 			<th><a onclick="return sortTable(this, 'Assets', textSort)" href="#">Assets</a> (<a href="https://github.com/google/syzkaller/blob/master/docs/syzbot_assets.md">help?</a>)</th>
@@ -447,16 +447,12 @@ Use of this source code is governed by Apache 2 LICENSE that can be found in the
 		<tr>
 			<td class="time">{{formatTime $b.Time}}</td>
 			<td class="kernel" title="{{$b.KernelAlias}}">{{$b.KernelAlias}}</td>
-			<td class="tag" title="{{$b.KernelCommit}}
-	{{formatTime $b.KernelCommitDate}}">{{link $b.KernelCommitLink (formatTagHash $b.KernelCommit)}}</td>
+			<td class="tag" title="{{$b.KernelCommit}} {{formatTime $b.KernelCommitDate}}">{{link $b.KernelCommitLink (formatTagHash $b.KernelCommit)}}</td>
 			<td class="tag">{{link $b.SyzkallerCommitLink (formatShortHash $b.SyzkallerCommit)}}</td>
 			<td class="config">{{if $b.KernelConfigLink}}<a href="{{$b.KernelConfigLink}}">.config</a>{{end}}</td>
 			<td class="repro">{{if $b.LogLink}}<a href="{{$b.LogLink}}">{{if $b.LogHasStrace}}strace{{else}}console{{end}} log</a>{{end}}</td>
 			<td class="repro">{{if $b.ReportLink}}<a href="{{$b.ReportLink}}">report</a>{{end}}</td>
-			<td class="repro{{if $b.ReproIsRevoked}} stale_repro{{end}}">
-				{{if $b.ReproSyzLink}}<a href="{{$b.ReproSyzLink}}">syz</a>{{end}}
-				{{if $b.ReproLogLink}} / <a href="{{$b.ReproLogLink}}">log</a>{{end}}
-			</td>
+			<td class="repro{{if $b.ReproIsRevoked}} stale_repro{{end}}">{{if $b.ReproSyzLink}}<a href="{{$b.ReproSyzLink}}">syz</a>{{end}}{{if $b.ReproLogLink}} / <a href="{{$b.ReproLogLink}}">log</a>{{end}}</td>
 			<td class="repro{{if $b.ReproIsRevoked}} stale_repro{{end}}">{{if $b.ReproCLink}}<a href="{{$b.ReproCLink}}">C</a>{{end}}</td>
 			<td class="repro">{{if $b.MachineInfoLink}}<a href="{{$b.MachineInfoLink}}">info</a>{{end}}</td>
 			<td class="assets">{{range $i, $asset := .Assets}}
-- 
cgit mrf-deployment