From 94243f0c885f79147a0c19cb2e11dae119683f81 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Tue, 15 Jul 2025 16:50:26 +0200 Subject: all: manual linter fixes 1. recover the removed comment 2. unnecessary leading newline 3. unnecessary brackets 4. restore dropped "..." 5. use bytes.Equal instead of conversion to string --- dashboard/app/kcidb.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'dashboard') diff --git a/dashboard/app/kcidb.go b/dashboard/app/kcidb.go index 7203c6dfa..f2cfeaacb 100644 --- a/dashboard/app/kcidb.go +++ b/dashboard/app/kcidb.go @@ -69,7 +69,10 @@ func publishKcidbBug(c context.Context, client *kcidb.Client, bug *Bug, bugKey * if err != nil { return false, err } - publish := !(rep.KernelCommit == "" || len(rep.KernelConfig) == 0) + // publish == false happens only for syzkaller build/test errors. + // But if this ever happens for a kernel bug, then we also don't want to publish such bugs + // with missing critical info. + publish := rep.KernelCommit != "" && len(rep.KernelConfig) != 0 if publish { if err := client.Publish(rep); err != nil { -- cgit mrf-deployment