From 584f940bafc44c485df4bdddca341ab7893f48ef Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Sat, 31 Aug 2019 19:06:56 -0700 Subject: dashboard/app: fix fix bisection tests Currently TestBisectFixRetry fails because it assumes emails about crash on ToT are not sent. But we currently send them in tests. Make the behavior consistent between tests and prod. Update #1371 --- dashboard/app/jobs.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'dashboard') diff --git a/dashboard/app/jobs.go b/dashboard/app/jobs.go index 23595e72d..9fadcb68d 100644 --- a/dashboard/app/jobs.go +++ b/dashboard/app/jobs.go @@ -575,10 +575,12 @@ func pollCompletedJobs(c context.Context, typ string) ([]*dashapi.BugReport, err continue } // TODO: this is temporal for gradual bisection rollout. - // Notify only about successful bisection for now. - // Note: If BisectFix results in a crash on HEAD, no notification is sent out. The following - // check also accounts for that condition. - if !appengine.IsDevAppServer() && job.Type != JobTestPatch && len(job.Commits) != 1 { + // Notify only about successful cause bisection for now. + if !appengine.IsDevAppServer() && job.Type == JobBisectCause && len(job.Commits) != 1 { + continue + } + // If BisectFix results in a crash on HEAD, no notification is sent out. + if job.Type == JobBisectFix && len(job.Commits) != 1 { continue } rep, err := createBugReportForJob(c, job, keys[i], reporting.Config) -- cgit mrf-deployment