From 4ea1fe6aae47bcfc828797d283ecbc755682e7c9 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Thu, 12 Dec 2024 15:35:24 +0100 Subject: tools/syz-covermerger: more logs I don't see any visible problems but the records in DB are not created. Let's report the amount of records created at the end of the batch step. +log the names of the managers --- dashboard/app/api.go | 4 ++-- dashboard/dashapi/dashapi.go | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) (limited to 'dashboard') diff --git a/dashboard/app/api.go b/dashboard/app/api.go index bfd3add1b..b70cac882 100644 --- a/dashboard/app/api.go +++ b/dashboard/app/api.go @@ -1906,7 +1906,7 @@ func apiSaveCoverage(c context.Context, r *http.Request, payload []byte) (interf sss = service.List() log.Infof(c, "found %d subsystems for %s namespace", len(sss), coverage.Namespace) } - err := coveragedb.SaveMergeResult( + rowsCreated, err := coveragedb.SaveMergeResult( context.Background(), appengine.AppID(context.Background()), coverage.FileData, @@ -1927,5 +1927,5 @@ func apiSaveCoverage(c context.Context, r *http.Request, payload []byte) (interf log.Infof(c, "updated coverage for ns %s, date %s to %d rows", coverage.Namespace, coverage.DateTo.String(), coverage.TotalRows) } - return nil, err + return &rowsCreated, err } diff --git a/dashboard/dashapi/dashapi.go b/dashboard/dashapi/dashapi.go index 9e1d29d0b..8133d47c5 100644 --- a/dashboard/dashapi/dashapi.go +++ b/dashboard/dashapi/dashapi.go @@ -704,8 +704,14 @@ type SaveCoverageReq struct { Coverage *MergedCoverage } -func (dash *Dashboard) SaveCoverage(req *SaveCoverageReq) error { - return dash.Query("save_coverage", req, nil) +// SaveCoverage returns amount of records created in db. +func (dash *Dashboard) SaveCoverage(req *SaveCoverageReq) (int, error) { + resp := new(int) + if err := dash.Query("save_coverage", req, resp); err != nil { + return 0, err + } else { + return *resp, err + } } type TestPatchRequest struct { -- cgit mrf-deployment