From 3b9d2b55c1947e93814ff87d3cf3b473d366cd4e Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Tue, 24 Jan 2023 14:26:10 +0100 Subject: dashboard: include report elements in the BugReport This will help optimize the detection and addition of missing fields to the existing reports. --- dashboard/app/reporting.go | 1 + dashboard/app/reporting_test.go | 2 ++ dashboard/dashapi/dashapi.go | 5 +++++ 3 files changed, 8 insertions(+) (limited to 'dashboard') diff --git a/dashboard/app/reporting.go b/dashboard/app/reporting.go index bb595686b..255296216 100644 --- a/dashboard/app/reporting.go +++ b/dashboard/app/reporting.go @@ -484,6 +484,7 @@ func crashBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key, NumCrashes: bug.NumCrashes, HappenedOn: managersToRepos(c, bug.Namespace, bug.HappenedOn), Assets: assetList, + ReportElements: &dashapi.ReportElements{GuiltyFiles: crash.ReportElements.GuiltyFiles}, } if bugReporting.CC != "" { rep.CC = append(rep.CC, strings.Split(bugReporting.CC, "|")...) diff --git a/dashboard/app/reporting_test.go b/dashboard/app/reporting_test.go index 0768d9105..a594e8356 100644 --- a/dashboard/app/reporting_test.go +++ b/dashboard/app/reporting_test.go @@ -84,6 +84,7 @@ func TestReportBug(t *testing.T) { NumCrashes: 1, HappenedOn: []string{"repo1 branch1"}, Assets: []dashapi.Asset{}, + ReportElements: &dashapi.ReportElements{}, } c.expectEQ(want, rep) @@ -247,6 +248,7 @@ func TestInvalidBug(t *testing.T) { NumCrashes: 1, HappenedOn: []string{"repo1 branch1"}, Assets: []dashapi.Asset{}, + ReportElements: &dashapi.ReportElements{}, } c.expectEQ(want, rep) c.client.ReportFailedRepro(testCrashID(crash1)) diff --git a/dashboard/dashapi/dashapi.go b/dashboard/dashapi/dashapi.go index 4c46d1582..17cd8df91 100644 --- a/dashboard/dashapi/dashapi.go +++ b/dashboard/dashapi/dashapi.go @@ -412,6 +412,11 @@ type BugReport struct { BisectFix *BisectResult Assets []Asset Subsystems []BugSubsystem + ReportElements *ReportElements +} + +type ReportElements struct { + GuiltyFiles []string } type BugSubsystem struct { -- cgit mrf-deployment