From b30f1509597cbc360ac686e3124e219dd8a49971 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 22 Dec 2025 11:19:25 +0100 Subject: dashboard/app: improve test names in TestUserAccessLevel The test uses test names with spaces, testing package replaces spaces with _. As the result, it's impossible to search for failed tests, and they all look very similar. Replace space with _, so that it's possible to search for failed tests. --- dashboard/app/access_test.go | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) (limited to 'dashboard/app') diff --git a/dashboard/app/access_test.go b/dashboard/app/access_test.go index 9b168d670..1141f40ee 100644 --- a/dashboard/app/access_test.go +++ b/dashboard/app/access_test.go @@ -486,58 +486,58 @@ func TestUserAccessLevel(t *testing.T) { wantIsAuthorized bool }{ { - name: "wrong auth domain", + name: "wrong_auth_domain", u: makeUser(BadAuthDomain), wantAccessLevel: AccessPublic, }, { - name: "regular not authenticated user", + name: "regular_not_authenticated_user", u: makeUser(Regular), wantAccessLevel: AccessPublic, }, { - name: "regular not authenticated user wants to be an admin", + name: "regular_not_authenticated_user_wants_to_be_an_admin", u: makeUser(Regular), enforcedAccessLevel: "admin", config: testConfig, wantAccessLevel: AccessPublic, }, { - name: "regular not authenticated user wants to be a user", + name: "regular_not_authenticated_user_wants_to_be_a_user", u: makeUser(Regular), enforcedAccessLevel: "user", config: testConfig, wantAccessLevel: AccessPublic, }, { - name: "authenticated, not authorized user", + name: "authenticated_not_authorized_user", u: makeUser(Authenticated), config: testConfig, wantAccessLevel: AccessPublic, }, { - name: "authenticated, not authorized user wants to be an admin", + name: "authenticated_not_authorized_user_wants_to_be_an_admin", u: makeUser(Authenticated), enforcedAccessLevel: "admin", config: testConfig, wantAccessLevel: AccessPublic, }, { - name: "authenticated, not authorized user wants to be a user", + name: "authenticated_not_authorized_user_wants_to_be_a_user", u: makeUser(Authenticated), enforcedAccessLevel: "user", config: testConfig, wantAccessLevel: AccessPublic, }, { - name: "authorized for AccessPublic user", + name: "authorized_for_AccessPublic_user", u: makeUser(AuthorizedAccessPublic), config: testConfig, wantAccessLevel: AccessPublic, wantIsAuthorized: true, }, { - name: "authorized for AccessPublic user wants to be an admin", + name: "authorized_for_AccessPublic_user_wants_to_be_an_admin", u: makeUser(AuthorizedAccessPublic), enforcedAccessLevel: "admin", config: testConfig, @@ -545,7 +545,7 @@ func TestUserAccessLevel(t *testing.T) { wantIsAuthorized: true, }, { - name: "authorized for AccessPublic user wants to be a user", + name: "authorized_for_AccessPublic_user_wants_to_be_a_user", u: makeUser(AuthorizedAccessPublic), enforcedAccessLevel: "user", config: testConfig, @@ -553,14 +553,14 @@ func TestUserAccessLevel(t *testing.T) { wantIsAuthorized: true, }, { - name: "authorized for AccessUser user", + name: "authorized_for_AccessUser_user", u: makeUser(AuthorizedUser), config: testConfig, wantAccessLevel: AccessUser, wantIsAuthorized: true, }, { - name: "authorized for AccessUser user wants to be an admin", + name: "authorized_for_AccessUser_user_wants_to_be_an_admin", u: makeUser(AuthorizedUser), enforcedAccessLevel: "admin", config: testConfig, @@ -568,14 +568,14 @@ func TestUserAccessLevel(t *testing.T) { wantIsAuthorized: true, }, { - name: "authorized admin wants AccessAdmin", + name: "authorized_admin_wants_AccessAdmin", u: makeUser(AuthorizedAdmin), config: testConfig, wantAccessLevel: AccessAdmin, wantIsAuthorized: true, }, { - name: "authorized admin wants AccessPublic", + name: "authorized_admin_wants_AccessPublic", u: makeUser(AuthorizedAdmin), enforcedAccessLevel: "public", config: testConfig, @@ -583,7 +583,7 @@ func TestUserAccessLevel(t *testing.T) { wantIsAuthorized: true, }, { - name: "authorized admin wants AccessUser", + name: "authorized_admin_wants_AccessUser", u: makeUser(AuthorizedAdmin), enforcedAccessLevel: "user", config: testConfig, -- cgit mrf-deployment