From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- dashboard/app/reporting_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'dashboard/app/reporting_test.go') diff --git a/dashboard/app/reporting_test.go b/dashboard/app/reporting_test.go index 1aa7a4979..7be5e023f 100644 --- a/dashboard/app/reporting_test.go +++ b/dashboard/app/reporting_test.go @@ -10,6 +10,7 @@ import ( "time" "github.com/google/syzkaller/dashboard/dashapi" + "github.com/google/syzkaller/sys/targets" ) func TestReportBug(t *testing.T) { @@ -45,9 +46,9 @@ func TestReportBug(t *testing.T) { Namespace: "test1", Config: []byte(`{"Index":1}`), ID: rep.ID, - OS: "linux", - Arch: "amd64", - VMArch: "amd64", + OS: targets.Linux, + Arch: targets.AMD64, + VMArch: targets.AMD64, First: true, Moderation: true, Title: "title1", @@ -208,9 +209,9 @@ func TestInvalidBug(t *testing.T) { Namespace: "test1", Config: []byte(`{"Index":1}`), ID: rep.ID, - OS: "linux", - Arch: "amd64", - VMArch: "amd64", + OS: targets.Linux, + Arch: targets.AMD64, + VMArch: targets.AMD64, First: true, Moderation: true, Title: "title1 (2)", -- cgit mrf-deployment