From 4e740c00a474b578896830c7d27d90d9474364bb Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 22 Oct 2020 18:59:10 +0200 Subject: dashboard/app: show more detailed info about bisections 1. Split cause/fix bisections in the bug table. 2. Show if bisection is inconclusive/unreliable in the bug table. 3. Show if bisection is unreliable on the bug page. Update #2098 --- dashboard/app/reporting.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'dashboard/app/reporting.go') diff --git a/dashboard/app/reporting.go b/dashboard/app/reporting.go index 775eaf759..54ad38cdd 100644 --- a/dashboard/app/reporting.go +++ b/dashboard/app/reporting.go @@ -356,14 +356,17 @@ func createBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key return nil, err } var job *Job - if bug.BisectCause == BisectYes { + reportBisection := bug.BisectCause == BisectYes || + bug.BisectCause == BisectInconclusive || + bug.BisectCause == BisectHorizont + if reportBisection { // If we have bisection results, report the crash/repro used for bisection. job1, crash1, _, crashKey1, err := loadBisectJob(c, bug, JobBisectCause) if err != nil { return nil, err } job = job1 - if !job.isUnreliableBisect() && (crash1.ReproC != 0 || crash.ReproC == 0) { + if crash1.ReproC != 0 || crash.ReproC == 0 { // Don't override the crash in this case, // otherwise we will always think that we haven't reported the C repro. crash, crashKey = crash1, crashKey1 @@ -444,7 +447,7 @@ func createBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key if build.Type == BuildFailed { rep.Maintainers = append(rep.Maintainers, kernelRepo.BuildMaintainers...) } - if bug.BisectCause == BisectYes && !job.isUnreliableBisect() { + if reportBisection { rep.BisectCause = bisectFromJob(c, rep, job) } if err := fillBugReport(c, rep, bug, bugReporting, build); err != nil { -- cgit mrf-deployment