From 7e805b6a42655e3b327f820cd56f88b99ab4db2a Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Fri, 26 Jul 2024 12:52:50 +0200 Subject: dashboard/app/coverage_batch.go: don't retry even on spot When running on Spot VMs, our batch jobs can get preempted and restarted. For some reason, GCP sometimes starts multiple instances of the same job, which results in duplicate results in the DB. Prevent this by dropping MaxRetryCount. Even if a job fails for a specific day, the data for that day will be processed on the following day, so it does not get lost. If needed, we can manually trigger recalc using /cron/batch_coverage. --- dashboard/app/coverage_batch.go | 1 - 1 file changed, 1 deletion(-) (limited to 'dashboard/app/coverage_batch.go') diff --git a/dashboard/app/coverage_batch.go b/dashboard/app/coverage_batch.go index 1e4b59d0f..9b314ada4 100644 --- a/dashboard/app/coverage_batch.go +++ b/dashboard/app/coverage_batch.go @@ -122,7 +122,6 @@ func createScriptJob(ctx context.Context, projectID, serviceAccount, script stri MaxRunDuration: &durationpb.Duration{ Seconds: batchTimeoutSeconds, }, - MaxRetryCount: 2, }, }, } -- cgit mrf-deployment