From 7bdf6e025f1fbbbc7af65f80ff7aa5922ff8e252 Mon Sep 17 00:00:00 2001
From: Dmitry Vyukov <dvyukov@google.com>
Date: Tue, 19 Jun 2018 13:06:02 +0200
Subject: dashboard/app: fix table sorting on firefox

Under Firefox 60 browser, sort operation does not work and

  ReferenceError: event is not defined

error message is printed in the Web Console window.
Let's explicitly pass an object reference to the sortTable function.

Credit goes to Tetsuo Handa.
---
 dashboard/app/bug.html | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

(limited to 'dashboard/app/bug.html')

diff --git a/dashboard/app/bug.html b/dashboard/app/bug.html
index 580454e23..c421b9db3 100644
--- a/dashboard/app/bug.html
+++ b/dashboard/app/bug.html
@@ -37,17 +37,17 @@ Page with details about a single bug.
 	<table class="list_table">
 		<caption>All crashes ({{.Bug.NumCrashes}}):</caption>
 		<tr>
-			<th><a onclick="return sortTable('Manager', textSort)" href="#">Manager</a></th>
-			<th><a onclick="return sortTable('Time', dateSort)" href="#">Time</a></th>
-			<th><a onclick="return sortTable('Kernel', textSort)" href="#">Kernel</a></th>
-			<th><a onclick="return sortTable('Commit', textSort)" href="#">Commit</a></th>
-			<th><a onclick="return sortTable('Syzkaller', textSort)" href="#">Syzkaller</a></th>
-			<th><a onclick="return sortTable('Config', textSort)" href="#">Config</a></th>
-			<th><a onclick="return sortTable('Log', textSort)" href="#">Log</a></th>
-			<th><a onclick="return sortTable('Report', reproSort)" href="#">Report</a></th>
-			<th><a onclick="return sortTable('Syz repro', reproSort)" href="#">Syz repro</a></th>
-			<th><a onclick="return sortTable('C repro', textSort)" href="#">C repro</a></th>
-			<th><a onclick="return sortTable('Maintainers', textSort)" href="#">Maintainers</a></th>
+			<th><a onclick="return sortTable(this, 'Manager', textSort)" href="#">Manager</a></th>
+			<th><a onclick="return sortTable(this, 'Time', dateSort)" href="#">Time</a></th>
+			<th><a onclick="return sortTable(this, 'Kernel', textSort)" href="#">Kernel</a></th>
+			<th><a onclick="return sortTable(this, 'Commit', textSort)" href="#">Commit</a></th>
+			<th><a onclick="return sortTable(this, 'Syzkaller', textSort)" href="#">Syzkaller</a></th>
+			<th><a onclick="return sortTable(this, 'Config', textSort)" href="#">Config</a></th>
+			<th><a onclick="return sortTable(this, 'Log', textSort)" href="#">Log</a></th>
+			<th><a onclick="return sortTable(this, 'Report', reproSort)" href="#">Report</a></th>
+			<th><a onclick="return sortTable(this, 'Syz repro', reproSort)" href="#">Syz repro</a></th>
+			<th><a onclick="return sortTable(this, 'C repro', textSort)" href="#">C repro</a></th>
+			<th><a onclick="return sortTable(this, 'Maintainers', textSort)" href="#">Maintainers</a></th>
 		</tr>
 		{{range $c := $.Crashes}}
 			<tr>
-- 
cgit mrf-deployment