From fc3361d7aff923f41fc39ef068717a720bc24bc8 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Sun, 9 Oct 2016 09:41:30 +0200 Subject: manager: enable fuzzer verbosity only if -debug flag is given It is not useful to pass manager verbosity flag to fuzzer, as fuzzer output is not visible. But it increases amount of fuzzer output that needs to be parsed by manager. Also increased fuzzer verbosity reduces effective crash log size (less programs fit). Enable fuzzer verbosity only if debug flag is given. --- syz-manager/manager.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/syz-manager/manager.go b/syz-manager/manager.go index 7869d4f19..ee09fe5fc 100644 --- a/syz-manager/manager.go +++ b/syz-manager/manager.go @@ -244,11 +244,15 @@ func (mgr *Manager) runInstance(vmCfg *vm.Config, first bool) bool { // Leak detection significantly slows down fuzzing, so detect leaks only on the first instance. leak := first && mgr.cfg.Leak + fuzzerV := 0 + if *flagDebug { + fuzzerV = 100 + } // Run the fuzzer binary. outc, errc, err := inst.Run(time.Hour, fmt.Sprintf( "%v -executor=%v -name=%v -manager=%v -output=%v -procs=%v -leak=%v -cover=%v -sandbox=%v -debug=%v -v=%d", - fuzzerBin, executorBin, vmCfg.Name, fwdAddr, mgr.cfg.Output, mgr.cfg.Procs, leak, mgr.cfg.Cover, mgr.cfg.Sandbox, *flagDebug, *flagV)) + fuzzerBin, executorBin, vmCfg.Name, fwdAddr, mgr.cfg.Output, mgr.cfg.Procs, leak, mgr.cfg.Cover, mgr.cfg.Sandbox, *flagDebug, fuzzerV)) if err != nil { logf(0, "failed to run fuzzer: %v", err) return false -- cgit mrf-deployment