From ee4e11c8201e61ce6155059daa9330824f9fad16 Mon Sep 17 00:00:00 2001 From: Konstantinos Andrikopoulos Date: Mon, 15 Jul 2024 20:44:00 +0200 Subject: syz-manager: properly parse host:port --- syz-manager/manager.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/syz-manager/manager.go b/syz-manager/manager.go index 05927bfc4..105117ef0 100644 --- a/syz-manager/manager.go +++ b/syz-manager/manager.go @@ -17,7 +17,6 @@ import ( "os/exec" "path/filepath" "runtime" - "strings" "sync" "sync/atomic" "time" @@ -741,8 +740,11 @@ func (mgr *Manager) runInstanceInner(ctx context.Context, inst *vm.Instance, ins mgr.bootTime.Save(time.Since(start)) start = time.Now() - addrPort := strings.Split(fwdAddr, ":") - cmd := fmt.Sprintf("%v runner %v %v %v", executorBin, instanceName, addrPort[0], addrPort[1]) + host, port, err := net.SplitHostPort(fwdAddr) + if err != nil { + return nil, nil, fmt.Errorf("failed to parse manager's address") + } + cmd := fmt.Sprintf("%v runner %v %v %v", executorBin, instanceName, host, port) _, rep, err := inst.Run(mgr.cfg.Timeouts.VMRunningTime, mgr.reporter, cmd, vm.ExitTimeout, vm.StopContext(ctx), vm.InjectExecuting(injectExec), vm.EarlyFinishCb(func() { -- cgit mrf-deployment