From e7f18c19fecebc6f1c55caed7b1145144079da16 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Tue, 25 Apr 2023 13:39:35 +0200 Subject: dashboard: list commands at the bottom of the reminder report This should make commands more visible to the users. --- dashboard/app/mail_subsystem.txt | 17 ++++++- dashboard/app/subsystem_test.go | 98 +++++++++++++++++++++++++++++++++++++--- 2 files changed, 108 insertions(+), 7 deletions(-) diff --git a/dashboard/app/mail_subsystem.txt b/dashboard/app/mail_subsystem.txt index 66b4e0f5b..b6a831ff2 100644 --- a/dashboard/app/mail_subsystem.txt +++ b/dashboard/app/mail_subsystem.txt @@ -14,9 +14,24 @@ Some of the still happening issues: {{- if .Moderation}} The report will be sent to: {{.Maintainers}}. -If the report looks fine to you, please send the "syz upstream" command. {{end}} --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem +{{- if .Moderation}} + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate +{{- end}} + +You may send multiple commands in a single email message. diff --git a/dashboard/app/subsystem_test.go b/dashboard/app/subsystem_test.go index dc5689535..806c37cf2 100644 --- a/dashboard/app/subsystem_test.go +++ b/dashboard/app/subsystem_test.go @@ -299,12 +299,25 @@ Ref Crashes Repro Title https://testapp.appspot.com/bug?extid=%[2]v The report will be sent to: [subsystemA@list.com subsystemA@person.com]. -If the report looks fine to you, please send the "syz upstream" command. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a second"])) // Expect the reminder for subsystemB. @@ -330,12 +343,25 @@ Ref Crashes Repro Title https://testapp.appspot.com/bug?extid=%[2]v The report will be sent to: [subsystemB@list.com subsystemB@person.com]. -If the report looks fine to you, please send the "syz upstream" command. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: b second"], bugToExtID["WARNING: b first"])) // Wait the next pair of reminders. @@ -413,6 +439,14 @@ Ref Crashes Repro Title This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a second"])) } @@ -532,12 +566,25 @@ Ref Crashes Repro Title https://testapp.appspot.com/bug?extid=%[6]v The report will be sent to: [subsystemA@list.com subsystemA@person.com]. -If the report looks fine to you, please send the "syz upstream" command. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: has repro 6"], bugToExtID["WARNING: no repro 6"], @@ -680,12 +727,25 @@ Ref Crashes Repro Title https://testapp.appspot.com/bug?extid=%[2]v The report will be sent to: [subsystemA@list.com subsystemA@person.com]. -If the report looks fine to you, please send the "syz upstream" command. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a third"])) } @@ -770,12 +830,25 @@ Ref Crashes Repro Title https://testapp.appspot.com/bug?extid=%[3]v The report will be sent to: [subsystemA@list.com subsystemA@person.com]. -If the report looks fine to you, please send the "syz upstream" command. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a second"], bugToExtID["WARNING: a third"], bugToExtID["WARNING: a fourth"])) @@ -826,11 +899,24 @@ Ref Crashes Repro Title https://testapp.appspot.com/bug?extid=%[2]v The report will be sent to: [subsystemA@list.com subsystemA@person.com]. -If the report looks fine to you, please send the "syz upstream" command. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. + +To disable reminders for individual bugs, reply with the following command: +#syz set no-reminders + +To change bug's subsystems, reply with: +#syz set subsystems: new-subsystem + +If the report looks fine to you, reply with: +#syz upstream + +To regenerate the report, reply with: +#syz regenerate + +You may send multiple commands in a single email message. `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a second"])) } -- cgit mrf-deployment