From c871758a7153287e1bf51aafb422dfd8ca1cde7e Mon Sep 17 00:00:00 2001
From: Dmitry Vyukov <dvyukov@google.com>
Date: Tue, 12 Mar 2019 13:05:03 +0100
Subject: dashboard/app: rename CommitInfo to Commit

Because why?
---
 dashboard/app/api.go      |  2 +-
 dashboard/app/entities.go | 24 ++++++++++++------------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/dashboard/app/api.go b/dashboard/app/api.go
index 022e94963..32cab3871 100644
--- a/dashboard/app/api.go
+++ b/dashboard/app/api.go
@@ -327,7 +327,7 @@ func addCommitInfoToBugImpl(c context.Context, bug *Bug, com dashapi.Commit) (bo
 		return false, nil
 	}
 	for len(bug.CommitInfo) < len(bug.Commits) {
-		bug.CommitInfo = append(bug.CommitInfo, CommitInfo{})
+		bug.CommitInfo = append(bug.CommitInfo, Commit{})
 	}
 	hash0 := bug.CommitInfo[ci].Hash
 	date0 := bug.CommitInfo[ci].Date
diff --git a/dashboard/app/entities.go b/dashboard/app/entities.go
index f68b641a9..72a967b2d 100644
--- a/dashboard/app/entities.go
+++ b/dashboard/app/entities.go
@@ -83,13 +83,13 @@ type Bug struct {
 	LastActivity   time.Time // last time we observed any activity related to the bug
 	Closed         time.Time
 	Reporting      []BugReporting
-	Commits        []string     // titles of fixing commmits
-	CommitInfo     []CommitInfo // git hashes of fixing commits (parallel array to Commits)
-	HappenedOn     []string     `datastore:",noindex"` // list of managers
-	PatchedOn      []string     `datastore:",noindex"` // list of managers
+	Commits        []string // titles of fixing commmits
+	CommitInfo     []Commit // additional info for commits (for historical reasons parallel array to Commits)
+	HappenedOn     []string `datastore:",noindex"` // list of managers
+	PatchedOn      []string `datastore:",noindex"` // list of managers
 }
 
-type CommitInfo struct {
+type Commit struct {
 	Hash   string
 	Author string
 	Date   time.Time
@@ -100,11 +100,11 @@ type BugReporting struct {
 	ID         string // unique ID per BUG/BugReporting used in commucation with external systems
 	ExtID      string // arbitrary reporting ID that is passed back in dashapi.BugReport
 	Link       string
-	CC         string // additional emails added to CC list (|-delimited list)
-	CrashID    int64  // crash that we've last reported in this reporting
-	Auto       bool   // was it auto-upstreamed/obsoleted?
-	ReproLevel dashapi.ReproLevel
-	OnHold     time.Time // if set, the bug must not be upstreamed
+	CC         string             // additional emails added to CC list (|-delimited list)
+	CrashID    int64              // crash that we've last reported in this reporting
+	Auto       bool               // was it auto-upstreamed/obsoleted?
+	ReproLevel dashapi.ReproLevel // may be less then bug.ReproLevel if repro arrived but we didn't report it yet
+	OnHold     time.Time          // if set, the bug must not be upstreamed
 	Reported   time.Time
 	Closed     time.Time
 }
@@ -380,11 +380,11 @@ func (bug *Bug) updateCommits(commits []string, now time.Time) {
 	bug.PatchedOn = nil
 }
 
-func (bug *Bug) getCommitInfo(i int) CommitInfo {
+func (bug *Bug) getCommitInfo(i int) Commit {
 	if i < len(bug.CommitInfo) {
 		return bug.CommitInfo[i]
 	}
-	return CommitInfo{}
+	return Commit{}
 }
 
 func kernelRepoInfo(build *Build) KernelRepo {
-- 
cgit mrf-deployment