From a98a8417f2c0dfdab1e8d3d49e8a7605340ada89 Mon Sep 17 00:00:00 2001
From: Taras Madan <tarasmadan@google.com>
Date: Thu, 13 Feb 2025 11:17:21 +0100
Subject: pkg/coveragedb: fix tests flakiness

Happy path testing rely on iter.Stop() call to be done before we close errCh.
---
 pkg/coveragedb/coveragedb.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pkg/coveragedb/coveragedb.go b/pkg/coveragedb/coveragedb.go
index e0a139371..50fbd0633 100644
--- a/pkg/coveragedb/coveragedb.go
+++ b/pkg/coveragedb/coveragedb.go
@@ -416,9 +416,9 @@ func FilesCoverageStream(ctx context.Context, client spannerclient.SpannerClient
 	resCh := make(chan *FileCoverageWithLineInfo)
 	errCh := make(chan error)
 	go func() {
-		defer iter.Stop()
-		defer close(resCh)
 		defer close(errCh)
+		defer close(resCh)
+		defer iter.Stop()
 		if err := readIterToChan(ctx, iter, resCh); err != nil {
 			errCh <- fmt.Errorf("readIterToChan: %w", err)
 		}
-- 
cgit mrf-deployment