From a591dd14217030b23cb158bdb135e8019d282d14 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 16 Feb 2023 15:12:27 +0100 Subject: syz-manager: report guilty files correctly Only set the guilty file field if it's non empty. Report guilty files for reproducers. --- syz-manager/manager.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/syz-manager/manager.go b/syz-manager/manager.go index dd7d5942f..7c0bd40e2 100644 --- a/syz-manager/manager.go +++ b/syz-manager/manager.go @@ -882,8 +882,8 @@ func (mgr *Manager) saveCrash(crash *Crash) bool { Log: crash.Output, Report: crash.Report.Report, MachineInfo: crash.machineInfo, - GuiltyFiles: []string{crash.Report.GuiltyFile}, } + setGuiltyFiles(dc, crash.Report) resp, err := mgr.dash.ReportCrash(dc) if err != nil { log.Logf(0, "failed to report crash to dashboard: %v", err) @@ -1073,6 +1073,7 @@ func (mgr *Manager) saveRepro(res *ReproResult) { ReproC: cprogText, Assets: mgr.uploadReproAssets(repro), } + setGuiltyFiles(dc, report) if _, err := mgr.dash.ReportCrash(dc); err != nil { log.Logf(0, "failed to report repro to dashboard: %v", err) } else { @@ -1245,6 +1246,12 @@ func (mgr *Manager) minimizeCorpus() { mgr.corpusDB.BumpVersion(currentDBVersion) } +func setGuiltyFiles(crash *dashapi.Crash, report *report.Report) { + if report.GuiltyFile != "" { + crash.GuiltyFiles = []string{report.GuiltyFile} + } +} + type CallCov struct { count int cov cover.Cover -- cgit mrf-deployment