From 6eb12242337d83872574660e27cfe2e8db463e48 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Tue, 22 Apr 2025 17:01:31 +0200 Subject: pkg/manager: log no longer needed reproductions We already mention the scheduled and started reproductions, but if the reproduction was not started intentionally, that makes the logs look very confusing. Print a log message if NeedRepro() returned false when we were to actually start the reproduction. --- pkg/manager/repro.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/manager/repro.go b/pkg/manager/repro.go index c9eb2f9a9..f9fb2d0e2 100644 --- a/pkg/manager/repro.go +++ b/pkg/manager/repro.go @@ -187,6 +187,7 @@ func (r *ReproLoop) Loop(ctx context.Context) { crash := r.popCrash() for { if crash != nil && !r.mgr.NeedRepro(crash) { + log.Logf(1, "reproduction of %q aborted: it's no longer needed", crash.FullTitle()) crash = nil // Now we might not need that many VMs. r.mu.Lock() -- cgit mrf-deployment