From 53c67432e69b0df4ff64448b944cbffaecec20f4 Mon Sep 17 00:00:00 2001 From: Marco Elver Date: Wed, 6 Apr 2022 23:01:09 +0200 Subject: dashboard/config/linux: set CONFIG_WERROR=n Our Clang+KASAN instance is breaking due to CONFIG_WERROR being turned on in x86_64 defconfig [1], which in turn is used to generate our baseline configs, and therefore has accidentally been enabled in our syzbot configs as well. This issue has been discussed in great detail when CONFIG_WERROR was first introduced, with the conclusion that it is the wrong default for runtime-test focused bots [2]. Therefore, disable CONFIG_WERROR for syzbot, to not have the odd compiler warning interrupt precious fuzzing time. [1] https://lore.kernel.org/all/000000000000008dae05dbfebd85@google.com/ [2] https://git.kernel.org/torvalds/c/b339ec9c229aaf399296 --- dashboard/config/linux/bits/base.yml | 3 +++ dashboard/config/linux/chromeos-5.10-base.config | 2 +- dashboard/config/linux/chromeos-5.10.config | 2 +- dashboard/config/linux/chromeos-5.15-base.config | 2 +- dashboard/config/linux/chromeos-5.15.config | 2 +- dashboard/config/linux/upstream-apparmor-kasan-base.config | 2 +- dashboard/config/linux/upstream-apparmor-kasan.config | 2 +- dashboard/config/linux/upstream-kcsan-base.config | 2 +- dashboard/config/linux/upstream-kcsan.config | 2 +- dashboard/config/linux/upstream-leak-base.config | 2 +- dashboard/config/linux/upstream-leak.config | 2 +- dashboard/config/linux/upstream-selinux-kasan-base.config | 2 +- dashboard/config/linux/upstream-selinux-kasan.config | 2 +- dashboard/config/linux/upstream-smack-kasan-base.config | 2 +- dashboard/config/linux/upstream-smack-kasan.config | 2 +- dashboard/config/linux/upstream-usb-base.config | 2 +- dashboard/config/linux/upstream-usb.config | 2 +- 17 files changed, 19 insertions(+), 16 deletions(-) diff --git a/dashboard/config/linux/bits/base.yml b/dashboard/config/linux/bits/base.yml index 1f43036ce..c9cf71a1e 100644 --- a/dashboard/config/linux/bits/base.yml +++ b/dashboard/config/linux/bits/base.yml @@ -26,6 +26,9 @@ config: - EXPERT - DEBUG_KERNEL + # Continuous fuzzing is more important than breaking on warnings. + - WERROR: n + # panic=86400: prevents kernel from rebooting so that we don't get reboot output in all crash reports. # Huge page overcommit is disabled by default, allowing some overcommit # with vm.nr_overcommit_hugepages is intended to give more coverage. diff --git a/dashboard/config/linux/chromeos-5.10-base.config b/dashboard/config/linux/chromeos-5.10-base.config index 74b4c5f44..b1d2df4c0 100644 --- a/dashboard/config/linux/chromeos-5.10-base.config +++ b/dashboard/config/linux/chromeos-5.10-base.config @@ -25,7 +25,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/chromeos-5.10.config b/dashboard/config/linux/chromeos-5.10.config index 9b8548bc7..3e492c8b1 100644 --- a/dashboard/config/linux/chromeos-5.10.config +++ b/dashboard/config/linux/chromeos-5.10.config @@ -25,7 +25,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/chromeos-5.15-base.config b/dashboard/config/linux/chromeos-5.15-base.config index a50654137..3e674cb3d 100644 --- a/dashboard/config/linux/chromeos-5.15-base.config +++ b/dashboard/config/linux/chromeos-5.15-base.config @@ -29,7 +29,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/chromeos-5.15.config b/dashboard/config/linux/chromeos-5.15.config index 5a5a56e35..a819ebd7f 100644 --- a/dashboard/config/linux/chromeos-5.15.config +++ b/dashboard/config/linux/chromeos-5.15.config @@ -29,7 +29,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-apparmor-kasan-base.config b/dashboard/config/linux/upstream-apparmor-kasan-base.config index 23fc3a11d..c340da531 100644 --- a/dashboard/config/linux/upstream-apparmor-kasan-base.config +++ b/dashboard/config/linux/upstream-apparmor-kasan-base.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-apparmor-kasan.config b/dashboard/config/linux/upstream-apparmor-kasan.config index 219e06667..67d64148b 100644 --- a/dashboard/config/linux/upstream-apparmor-kasan.config +++ b/dashboard/config/linux/upstream-apparmor-kasan.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-kcsan-base.config b/dashboard/config/linux/upstream-kcsan-base.config index e1b495841..19c9256e3 100644 --- a/dashboard/config/linux/upstream-kcsan-base.config +++ b/dashboard/config/linux/upstream-kcsan-base.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-kcsan.config b/dashboard/config/linux/upstream-kcsan.config index 878adb8a8..91ab3be30 100644 --- a/dashboard/config/linux/upstream-kcsan.config +++ b/dashboard/config/linux/upstream-kcsan.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-leak-base.config b/dashboard/config/linux/upstream-leak-base.config index db3c0d14b..6c68d8bf0 100644 --- a/dashboard/config/linux/upstream-leak-base.config +++ b/dashboard/config/linux/upstream-leak-base.config @@ -29,7 +29,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-leak.config b/dashboard/config/linux/upstream-leak.config index c947f3e72..1804c0d9a 100644 --- a/dashboard/config/linux/upstream-leak.config +++ b/dashboard/config/linux/upstream-leak.config @@ -29,7 +29,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-selinux-kasan-base.config b/dashboard/config/linux/upstream-selinux-kasan-base.config index db3a05eb3..0059802ec 100644 --- a/dashboard/config/linux/upstream-selinux-kasan-base.config +++ b/dashboard/config/linux/upstream-selinux-kasan-base.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-selinux-kasan.config b/dashboard/config/linux/upstream-selinux-kasan.config index d9f332c38..cd7342e91 100644 --- a/dashboard/config/linux/upstream-selinux-kasan.config +++ b/dashboard/config/linux/upstream-selinux-kasan.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-smack-kasan-base.config b/dashboard/config/linux/upstream-smack-kasan-base.config index 7c76eb447..e7063c04e 100644 --- a/dashboard/config/linux/upstream-smack-kasan-base.config +++ b/dashboard/config/linux/upstream-smack-kasan-base.config @@ -31,7 +31,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-smack-kasan.config b/dashboard/config/linux/upstream-smack-kasan.config index 18cccaf96..52c41242a 100644 --- a/dashboard/config/linux/upstream-smack-kasan.config +++ b/dashboard/config/linux/upstream-smack-kasan.config @@ -31,7 +31,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-usb-base.config b/dashboard/config/linux/upstream-usb-base.config index 2c8f45e63..0b4928b4c 100644 --- a/dashboard/config/linux/upstream-usb-base.config +++ b/dashboard/config/linux/upstream-usb-base.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" diff --git a/dashboard/config/linux/upstream-usb.config b/dashboard/config/linux/upstream-usb.config index f96e592f4..85ab253dd 100644 --- a/dashboard/config/linux/upstream-usb.config +++ b/dashboard/config/linux/upstream-usb.config @@ -30,7 +30,7 @@ CONFIG_THREAD_INFO_IN_TASK=y # CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set -CONFIG_WERROR=y +# CONFIG_WERROR is not set CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" -- cgit mrf-deployment