From 34833561f1be2d0a9fb1e76a06bb11f2a4f9b06e Mon Sep 17 00:00:00 2001 From: Paul Chaignon Date: Sat, 4 Apr 2020 17:02:07 +0200 Subject: syz-fuzzer: Fix cyclo. complexity error syz-fuzzer/testing.go:104:1: cyclomatic complexity 27 of func `checkMachine` is high (> 24) func checkMachine(args *checkArgs) (*rpctype.CheckArgs, error) { ^ Signed-off-by: Paul Chaignon --- syz-fuzzer/testing.go | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/syz-fuzzer/testing.go b/syz-fuzzer/testing.go index 68dbb1e55..0ef837801 100644 --- a/syz-fuzzer/testing.go +++ b/syz-fuzzer/testing.go @@ -101,24 +101,26 @@ func convertTestReq(target *prog.Target, req *rpctype.RunTestPollRes) *runtest.R return test } +func checkMachineHeartbeats(done chan bool) { + ticker := time.NewTicker(3 * time.Second) + defer ticker.Stop() + for { + select { + case <-done: + return + case <-ticker.C: + fmt.Printf("executing program\n") + } + } +} + func checkMachine(args *checkArgs) (*rpctype.CheckArgs, error) { log.Logf(0, "checking machine...") // Machine checking can be very slow on some machines (qemu without kvm, KMEMLEAK linux, etc), // so print periodic heartbeats for vm.MonitorExecution so that it does not decide that we are dead. done := make(chan bool) defer close(done) - go func() { - ticker := time.NewTicker(3 * time.Second) - defer ticker.Stop() - for { - select { - case <-done: - return - case <-ticker.C: - fmt.Printf("executing program\n") - } - } - }() + go checkMachineHeartbeats(done) if err := checkRevisions(args); err != nil { return nil, err } -- cgit mrf-deployment