From 12365b99ce83b8a58433eaedbe412dff563ef8fb Mon Sep 17 00:00:00 2001 From: Marco Vanotti Date: Thu, 7 Mar 2019 18:03:49 -0800 Subject: syz-ci: fix error reporting for syzupdater. syzupdater fails to report build errors because it is constructing the dashapi client with the wrong parameters (it is mixing dashboardAddr with dashboardClient). This commit swaps the order of those parameters in syzupdater's uploadBuildError function. Fixes #1044 --- syz-ci/syzupdater.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/syz-ci/syzupdater.go b/syz-ci/syzupdater.go index ca5e13251..c2c5b1961 100644 --- a/syz-ci/syzupdater.go +++ b/syz-ci/syzupdater.go @@ -290,7 +290,7 @@ func (upd *SyzUpdater) uploadBuildError(commit *vcs.Commit, buildErr error) { log.Logf(0, "not uploading build error: no dashboard") return } - dash := dashapi.New(upd.dashboardAddr, upd.mgrcfg.DashboardClient, upd.mgrcfg.DashboardKey) + dash := dashapi.New(upd.mgrcfg.DashboardClient, upd.dashboardAddr, upd.mgrcfg.DashboardKey) var title string var output []byte if verbose, ok := buildErr.(*osutil.VerboseError); ok { -- cgit mrf-deployment