| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Any is the preferred over interface{} now in Go.
|
| |
|
|
| |
Any is the preferred over interface{} now in Go.
|
| | |
|
| |
|
|
|
| |
Loop variables are per-iteration, not per loop since go122.
https://go.dev/blog/loopvar-preview
|
| |
|
|
| |
They are shorter, more readable, and don't require temp vars.
|
| |
|
|
| |
Check tool.Failf messages for the common style as well.
|
| |
|
|
|
| |
Fix checking of Logf, it has string in 0-th arg.
Add checking of t.Errorf/Fatalf.
|
| |
|
|
|
| |
time.Now/Since may reject to use monotonic time if the fuzzer
messes with system time badly enough. Enforce use of monotonic time.
|
| |
|
|
|
|
|
| |
We have a variety of T.Logf() methods, while in most cases there's no
need to add signatures of each individual method to the syz-linter.
Co-authored-by: Dmitry Vyukov <dvyukov@google.com>
|
| |
|
|
|
|
|
|
|
|
| |
This commit address the following warning:
WARN plugin: 'AnalyzerPlugin' plugins are deprecated, please use
the new plugin signature:
https://golangci-lint.run/contributing/new-linters/#create-a-plugin
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
|
| |
|
|
| |
Now that we might have two, it might be helpful to split the logs.
|
| |
|
|
|
|
|
|
| |
Duplicate parameter type warning suggests to replace
"a int, b int" with "a, b int" in function declarations.
Currently it does not work for non-builtin types because
we compare type pointers directly but they are different
for non-builtin types. Compare type strings instead.
|
| |
|
|
|
| |
No space is allowed between // and go:embed. Make linter not throw a
warning about it.
|
| |
|
|
|
|
|
|
|
|
|
| |
"make generate" produces this diff when go 1.17 (go1.17-c95464f0ea3f==upstream)
is used. Seems compatible with >=1.16.
https://github.com/golang/go/commit/4d2d89ff42ca documents the syntax.
https://github.com/golang/go/commit/eeadce2d8713 enforces "ignore" for
unsatisfiable tags hence the pkg/csource/gen.go change.
Signed-off-by: Alexey Kardashevskiy <aik@linux.ibm.com>
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Check for capitalization, dots at the end
and two spaces after a period.
Update #1876
|
| |
|
|
|
|
|
| |
Turns out ast.Inspect does not visit most comments.
Walk file.Comments manually.
Update #1876
|
| |
|
|
|
|
| |
Enable some x/tools linters that are not enabled in vet.
Update #1876
|
| |
|
|
|
|
|
| |
Introduce a helper Pass type so that we can have
some helper methods on it.
Update #1876
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Warn about:
var x int = foo
In most cases this can be expressed shorter as:
var x int
x := foo
x := int(foo)
Update #1876
|
| |
|
|
| |
Update #1876
|
| |
|
|
| |
Update #1876
|
| |
|
|
| |
Update #1876
|
| |
|
|
|
|
|
|
| |
Add check for:
func foo(a int, b int) -> func foo(a, b int)
Update #1876
|
| |
|
|
| |
Update #1876
|
|
|
For now we have 2 simple checks:
1. for multiline comments:
/* */ -> //
2. for string len comparison with 0:
len(str) != 0 -> str != ""
Update #1876
|
