aboutsummaryrefslogtreecommitdiffstats
path: root/tools/syz-check
Commit message (Collapse)AuthorAgeFilesLines
* all: remove unused nolint directivesDmitry Vyukov2026-01-021-2/+2
|
* all: use any instead of interface{}Dmitry Vyukov2025-12-221-2/+2
| | | | Any is the preferred over interface{} now in Go.
* all: apply linter auto fixesTaras Madan2025-07-171-1/+1
| | | | ./tools/syz-env bin/golangci-lint run ./... --fix
* pkg/symbolizer: introduce Symbolizer interfaceTaras Madan2025-03-071-4/+3
| | | | To simplify interface Read*Symbols were moved out from symbolizer.Symbolizer.
* all: use min/max functionsDmitry Vyukov2025-01-171-9/+5
| | | | They are shorter, more readable, and don't require temp vars.
* all: use special placeholder for errorsTaras Madan2023-07-241-1/+1
|
* all: tools/syz-env make generate resultTaras Madan2023-02-241-0/+1
|
* pkg/ast, pkg/compiler: support per-file metadataDmitry Vyukov2022-04-291-4/+0
| | | | | | | | | | | | | | | | | | | | | We have a bunch of hacks in syz-extract, syz-sysgen and syz-check with respect to description files unsupported on some arches, or that must not be part of make extract. Add 2 meta attribtues to files: meta noextract Tells `make extract` to not extract constants for this file. Though, `syz-extract` can still be invoked manually on this file. meta arches["arch1", "arch2"] Restricts this file only to the given set of architectures. `make extract` and ``make generate` will not use it on other architectures. Later we can potentially use meta attributes to specify git tree/commit that must be used for extraction. Maybe something else. Fixes #2754
* tools/syz-check: ignore structs with out_overlay attributeDmitry Vyukov2022-01-131-0/+14
|
* tools/syz-check: calculate min type size for unionsDmitry Vyukov2022-01-131-10/+20
|
* tools/syz-check: don't check netlink policies as structsDmitry Vyukov2022-01-131-20/+19
| | | | They are not really structs in the kernel even if we describe them as structs.
* tools/syz-check: update docsDmitry Vyukov2022-01-131-1/+8
| | | | | Mention issue with DWARF4+ and bitfields. Mention kernel configs that must be used for kernel builds.
* sys/linux: change netlink policies to the new $ conventionDmitry Vyukov2022-01-131-1/+1
|
* tools/syz-check: use $ as struct variant suffix delimiterDmitry Vyukov2022-01-131-15/+12
| | | | | | | | | | We already use this $ convention for syscall variant names. Use the same convention for struct. Currently syz-check supports '_' for structs, but it's inconsistent with syscalls and leads to ambiguity. If we enable the same matching for all structs (not just netlink), then '_' creates lots of false matches. E.g. bpf_link_get_next_id_args is matches with internal bpf_link struct.
* all: use tool.Failf instead of local functionsDmitry Vyukov2020-12-251-5/+1
|
* pkg/cmdprof: merge into pkg/toolDmitry Vyukov2020-12-251-3/+2
| | | | cmdprof functionality seems to fit well into pkg/tool.
* sys/targets: add OS/Arch name constsDmitry Vyukov2020-10-261-3/+3
| | | | | | | | | | | | We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere.
* pkg/compiler: merge const files into a single fileDmitry Vyukov2020-08-131-1/+1
| | | | | | | | | | | | | | | | | | | | We now have 8 arches for Linux and .const files produce lots of noise in PRs and lots of diffs. If 3 .txt files are touched, the PR will have 24 .const files, which will be intermixed with .txt files. Frequently const values are equal across arches, and even if they don't spreading a single value across 8 files is inconvinient. Merge all 8 *_arch.const files into a single .const file. See the test for details of the new format. The old format is still parsed for now, we can't update all OSes at once. For Linux this reduces number of const files/lines from 1288/96599 to 158/11603. Fixes #1983
* tools/syz-linter: fix comments checkDmitry Vyukov2020-07-101-1/+1
| | | | | | | Turns out ast.Inspect does not visit most comments. Walk file.Comments manually. Update #1876
* tools/syz-check: improve warning for NLA_REJECTDmitry Vyukov2020-07-081-2/+4
|
* tools/syz-check: support all archesDmitry Vyukov2020-06-261-2/+2
|
* pkg: support compiler triple for 'nm' and 'addr2line'Alexander Egorenkov2020-06-181-1/+2
| | | | In preparation to support big-endian architectures.
* sys/linux: regenerate .warn filesDmitry Vyukov2020-06-131-1/+2
| | | | | On latest kernel, with latest *.txt files and with kernels compiled with -fno-eliminate-unused-debug-types -fno-eliminate-unused-debug-symbols flags.
* tools/syz-check: fix bug with struct name overwriteDmitry Vyukov2020-06-131-12/+16
| | | | | | | We patched name in struct object, but the dwarf package caches then and then can return in subsequent invocations. This causes a struct name to be overwritten by typedef name. Don't mutate returned struct objects.
* .golangci.yml: make goconst checker more strictDmitry Vyukov2020-06-071-4/+9
|
* tools/syz-check: restore handling of unionsDmitry Vyukov2020-05-251-81/+96
| | | | Unions were dropped accidentially during removal StructDesc.
* tools/syz-check: don't check kvm on armDmitry Vyukov2020-05-251-0/+4
|
* tools/syz-check: fix field name in outputDmitry Vyukov2020-05-251-1/+1
|
* tools/syz-check: fix path calculationDmitry Vyukov2020-05-211-1/+1
| | | | pkg/ast now gives full file name in Pos.
* prog: remove StructDescDmitry Vyukov2020-05-031-34/+28
| | | | | | | | | | | | Remove StructDesc, KeyedStruct, StructKey and all associated logic/complexity in prog and pkg/compiler. We can now handle recursion more generically with the Ref type, and Dir/FieldName are not a part of the type anymore. This makes StructType/UnionType simpler and more natural. Reduces size of sys/linux/gen/amd64.go from 5201321 to 4180861 (-20%). Update #1580
* prog: introduce Field typeDmitry Vyukov2020-05-021-22/+23
| | | | | | | | | | | | | Remvoe FieldName from Type and add a separate Field type that holds field name. Use Field for struct fields, union options and syscalls arguments, only these really have names. Reduces size of sys/linux/gen/amd64.go from 5665583 to 5201321 (-8.2%). Allows to not create new type for squashed any pointer. But main advantages will follow, e.g. removing StructDesc, using TypeRef in Arg, etc. Update #1580
* prog: rename {PtrType,ArrayType}.Type to ElemDmitry Vyukov2020-05-011-3/+3
| | | | | | | Name "Type" is confusing when referring to pointer/array element type. Frequently there are too many Type/typ/typ1/t and typ.Type is not very informative. It _is_ a type, but what's usually more relevant is that it's an _element_ type. Let's leave type checking to compiler and give it a more meaningful name.
* pkg/cmdprof: add packageDmitry Vyukov2020-04-301-30/+5
| | | | | | | cmdprof simplifies cpu/memory profiling for command line tools. Use as: flag.Parse() defer cmdprof.Install
* pkg/compiler: deduplicate Types in descriptionsDmitry Vyukov2020-04-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add prog.Ref Type that serves as a proxy for real types and allows to deduplicate Types in generated descriptions. The Ref type is effectively an index in an array of types. Just before serialization pkg/compiler replaces real types with the Ref types and prepares corresponding array of real types. When a Target is registered in prog package, we do the opposite operation and replace Ref's with the corresponding real types. This brings improvements across the board: compiler memory consumption is reduced by 15%, test building time by 25%, descriptions size by 33%. Before: $ du -h sys/linux/gen 54M sys/linux/gen $ time GOMAXPROCS=1 go test -p=1 -c ./prog real 0m54.200s real 0m53.883s $ time GOMAXPROCS=1 go install -p=1 ./tools/syz-execprog real 0m27.911s real 0m27.767s $ TIME="%e %P %M" GOMAXPROCS=1 time go tool compile ./sys/linux/gen 20.59 100% 3200016 20.97 100% 3445976 20.25 100% 3209684 After: $ du -h sys/linux/gen 36M sys/linux/gen $ time GOMAXPROCS=1 go test -p=1 -c ./prog real 0m42.290s real 0m43.230s $ time GOMAXPROCS=1 go install -p=1 ./tools/syz-execprog real 0m24.337s real 0m24.727s $ TIME="%e %P %M" GOMAXPROCS=1 time go tool compile ./sys/linux/gen 19.11 100% 2764952 19.66 100% 2787624 19.35 100% 2749376 Update #1580
* tools/syz-check: extend usage docsDmitry Vyukov2020-03-181-3/+22
| | | | Allow to run for only 1 arch and extend docs.
* all: fix new golangci-lint warningsDmitry Vyukov2020-03-131-3/+3
| | | | Newer version started producing more warnings. Fix them.
* sys/linux: add ethtool netlink descriptionsDmitry Vyukov2020-01-281-1/+1
|
* tools/syz-check: add limited checking of varlen structsDmitry Vyukov2020-01-231-6/+13
| | | | | | | | Stop at the fist varlen field, but check the preceeding ones. Frequently the varlen array is the last field, so we should get good checking for these cases. Update #590
* sys/linux: check for missing/duplicate netlink attrsDmitry Vyukov2020-01-231-3/+64
| | | | Update #590
* sys/linux: fix more netlink warningsDmitry Vyukov2020-01-231-9/+38
| | | | | | | | | | Handle NLA_BITFIELD32. Match string attribtues better. Calculate and check min size for varlen structs. Fix NLA_UNSPEC size check. Fix some things in descriptions. Update #590
* tools/syz-check: improve matching netlink attributesDmitry Vyukov2020-01-221-48/+102
| | | | | | | | | | 1. Match policies that has a _suffix in our descriptions (we frequently do this to improve precision or avoid dup names). 2. Rename policies in descriptions to match kernel names. 3. Match policy if there are several such names in kernel. 4. Recognize policies with helper sub-policies. Update #590
* tools/syz-check: check netlink policy descriptionsDmitry Vyukov2020-01-221-17/+297
| | | | | | | | | | | | | | Overall idea of netlink checking. Currnetly we check netlink policies for common detectable mistakes. First, we detect what looks like a netlink policy in our descriptions (these are structs/unions only with nlattr/nlnext/nlnetw fields). Then we find corresponding symbols (offset/size) in vmlinux using nm. Then we read elf headers and locate where these symbols are in the rodata section. Then read in the symbol data, which is an array of nla_policy structs. These structs allow to easily figure out type/size of attributes. Finally we compare our descriptions with the kernel policy description. Update #590
* sys/linux: fix sigset_t/sigaction layout on armDmitry Vyukov2020-01-181-0/+3
| | | | Update #590
* tools/syz-check: also check arm/arm64Dmitry Vyukov2020-01-181-13/+15
| | | | | | | | | They mostly duplicate the warnings we already have for amd64/386. But uncovered few very interesting local things (e.g. epoll_event is packed only on amd64, so arm/arm64 layout is wrong, but 386 is correct because int64 alignment is different). Update #590
* tools/syz-check: check amd64 and 386 at the same timeDmitry Vyukov2019-12-222-40/+80
| | | | Update #590
* tools/syz-check: check templatesDmitry Vyukov2019-12-221-10/+28
| | | | | | Also rename some netfilter types to eliminate massive amounts of template warnings. Update #590
* tools/syz-check: add some TODOsDmitry Vyukov2019-12-221-0/+12
|
* tools/syz-check: inject description compilation warningsDmitry Vyukov2019-12-201-8/+10
| | | | | | | | Currently we print them as part of `make genereate`, but nobody reads them, too much output each time. Don't print them in `make generate` and instead print in syz-check, the warn files are a good mechanism to handle "known warnings".
* pkg/compiler: fix bitfield layout bugDmitry Vyukov2019-12-201-6/+10
| | | | | | Fixes #1542 Found thanks to syz-check. Update #590
* prog: refactor bitfields representationDmitry Vyukov2019-12-191-5/+3
| | | | | | | | All callers of BitfieldMiddle just want static size (0 for middle). Make it so: Size for middle bitfields just returns 0. Removes lots of if's. Introduce Type.UnitSize, which now holds the underlying type for bitfields. This will be needed to fix #1542 b/c even if UnitSize=4 for last bitfield Size can be anywhere from 0 to 4 (not necessary equal to UnitSize due to overlapping).
generated by ggit (джигит) mrf-deployment (git 2.46.0) at 2026-03-11 18:06:47 +0000