| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
|
| |
Permit the following scenario: a finding is first submitted without a C
reproducer and then resubmitted again, now with one.
Ensure that it's only possible as long as the session is still in
progress.
Refactor Finding repository and service and adjust the tests.
|
| |
|
|
|
|
|
|
|
| |
Even if the target tree is specified in the patch title, there happen to
be cases when it's actually only applicable to some other trees.
So instead of choosing one particular tree and sticking to it, obtain an
ordered list of candidates and pick the first to which the series
actually applies.
|
| |
|
|
|
|
|
|
| |
We used to only upload them on triage failure, but let's improve the
inspectability even for successfully finished triage jobs.
Slightly refactor the controller API around the triage result
submission.
|
| |
|
|
|
|
| |
Fuzz bpf patches differently from net patches.
Monitor netfilter and bpf mailing lists
|
| |
|
|
|
| |
Update the email template to include a suggestion to add a Tested-By tag
to the affected series.
|
| | |
|
| |
|
|
| |
Cc syzkaller-bugs@googlegroups.com in all upstreamed syzbot ci findings.
|
| |
|
|
|
|
|
| |
Current results show that way too many series do not apply to the
non-next versions of their corresponding trees. So let's make -next the
default choice unless it the opposite was specified in the series
subject.
|
| |
|
|
|
| |
Add several more network-related trees, including those that will only
be selected if mentioned directly.
|
| |
|
|
|
| |
If a kernel tree was mentioned in the series subject, pick it regardless
of other factors.
|
| |
|
|
|
| |
Sometimes the patch series directly hint at the kernel tree they should
be applied to. Extract and remember this information.
|
| |
|
|
|
|
|
|
|
| |
Currently, the list was both within the Series object and within the
SessionReport object that also encloses Series. And, since only was was
actually filled, we were unable to actually Cc the people from the
series.
Keep only the Cc list in the Series object and adjust the tests.
|
| |
|
|
|
|
|
|
| |
Share not just the tree name (mainline, net, etc), but also the full URL
to check out the repository.
For that, add one more field to the Build entity and adjust email
reporting templates.
|
| |
|
|
| |
./tools/syz-env bin/golangci-lint run ./... --fix
|
| |
|
|
| |
Include a list of findings only if there are several of them.
|
| |
|
|
|
| |
When sending via dashapi, we used to only include the raw email address.
Include the bot's name there as well.
|
| |
|
|
| |
We send plain text emails, there's no reason to escape them.
|
| | |
|
| |
|
|
|
| |
Take web dashboard URL from the config and use it to generate links for
logs, reproducers, etc.
|
| |
|
|
|
|
|
| |
Fill in build details per each finding and display that information in
the report email.
Extend the test that verifies how api.SessionReport is filled.
|
| |
|
|
| |
We don't have the doc (yet), so let's not mention it.
|
| |
|
|
| |
This will facilitate code reuse.
|
| |
|
|
| |
Since these may be included into email addresses, keep them short.
|
| |
|
|
|
| |
Refactor the configuration to support both SMTP and dashapi-based email
sending functionality.
|
| | |
|
| |
|
|
|
|
| |
Replace an UpdateReport() call with a RecordReply(). This will
eventually allow us to support the email sender implementations for
which we do not immediately know the MessageID of the reported message.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Make blob store URIs dependent on the IDs explicitly passed into the
Write() function. In many cases this removes the need to distinguish
between the case when the object has already been saved and we must
overwrite it and when it's saved the first time.
Keep on first storing the object to the blob storage and only then
submitting the entities to Spanner. This will lead to some wasted space,
but we'll add garbage collection at some point.
|
| |
|
|
|
| |
Don't restart the job if it returned a non-zero exit code.
Don't treat the ErrNoChange error as a failure.
|
| |
|
|
|
| |
Add a test that verifies that we have correct down migrations.
Fix the down migrations sql file.
|
| |
|
|
|
|
|
|
|
|
| |
Add the functionality to poll the specified LKML git archive for the new
user replies under the bot's messages.
Check out the repository and pull it once in the specified time period.
Keep track of the latest processed commit hash.
Track the original report ID via In-Reply-To references.
|
| |
|
|
|
| |
Add API to record replies under the reports that allows to determine the
original report only by having the MessageID.
|
| |
|
|
|
|
|
|
| |
Since email-reporter is anyway tied to a specific reporting channel,
let's keep reporter names less generic.
Using "lkml" instead of just "email" will also let us generate proper
links to the email discussions based only on Reporter+MessageID.
|
| |
|
|
|
| |
Add the high-level logic for the email-reporter component that will
be responsible for sending bug reports and reacting to incoming emails.
|
| |
|
|
|
| |
Move the configuration from pkg/report to pkg/app and extend it with
more information.
|
| |
|
|
|
|
|
| |
Move more API-related helpers to the controller package to reduce code
duplication in tests.
Enable other packages to use pkg/reporter in their tests.
|
| |
|
|
| |
Enable reuse of the functionality in higher-level tests.
|
| |
|
|
|
| |
Introduce a Reporter column to the SessionReport.
For finished reports, store both a MessageID instead of Link.
|
| |
|
|
|
|
|
|
|
| |
Environment variables are convenient for storing values like DB or GCS
bucket names, but structured formats are more convenient for the actual
service configuration.
Separate global-config from global-config-env and add the functionality
that queries and parses the config options.
|
| |
|
|
|
|
|
|
|
| |
If the workflow step crashed or timed out, we used to have Running
status for such steps even though the session itself may be long
finished.
In order to prevent this inconsistency, on finishing each session go
through all remaining running steps and update their status to Error.
|
| |
|
|
|
|
|
|
| |
A raw InsertOrUpdate method is not very reliable in case of concurrent
update requests. Add a callback inside which the modified fields would
be set.
Refactor the existing code that used to call the old method.
|
| |
|
|
|
| |
If the series was skipped during triage, show that in the status and let
users filter by it.
|
| |
|
|
| |
For now, only share it for the skipped series.
|
| |
|
|
|
|
|
|
| |
The existing "no suitable commits found" reason is way too ambiguous.
Make CommitSelector return the exact reason why it decides not to
proceed with the particular patch series and display the reason on the
web dashboard.
|
| |
|
|
|
|
|
|
|
|
|
| |
The archive would be a useful source of debugging information.
Provide an HTTP endpoint that accepts a multipart form request with
the archived data.
Provide an *api.Client method to encapsulate the encoding of the data.
Add a test.
|
| |
|
|
| |
Add a checkbox to only display the series for which there are findings.
|
| |
|
|
| |
It will help identify the series to highlight.
|
| |
|
|
|
|
| |
In the tests, we often spawn different dummy objects.
Add a separate helper class to avoid duplicating this code.
|
| |
|
|
|
| |
Add simple Previous/Next navigation for the list of series.
For now, just rely on SQL's LIMIT/OFFSET functionality.
|
| |
|
|
| |
Update the Web UI to have a filter form on top of the index page.
|