aboutsummaryrefslogtreecommitdiffstats
path: root/pkg/ast
Commit message (Collapse)AuthorAgeFilesLines
* all: use any instead of interface{}Dmitry Vyukov2025-12-222-5/+5
| | | | Any is the preferred over interface{} now in Go.
* tools/syz-declextract: ignore files with non US-ASCII charsDmitry Vyukov2025-04-152-9/+15
|
* pkg/declextract: remove unused includes and definesDmitry Vyukov2025-01-171-1/+1
| | | | | | | | | | This is nice on its own, but this will also help to prevent lots of problems when we export more info from the clang tool in future. The clang tool does not know what will end up in the final descriptions, so it exports info about all consts that it encounters. As the result we pull in lots of includes/defines, and lots of kernel includes/defines are broken or create problems. So the fewer we have, the better.
* all: use min/max functionsDmitry Vyukov2025-01-171-3/+1
| | | | They are shorter, more readable, and don't require temp vars.
* pkg/compiler: add automatic metaDmitry Vyukov2024-12-111-0/+1
| | | | | | Mark the whole file with "meta automatic" instead of marking each syscall. This reduces size of descriptions + allows to do special things with the whole file (e.g. we already treat auto consts specially).
* all: support || operator in syzlang if conditionJiao, Joey2024-11-136-5/+24
| | | | | | | | | | | ex. f3 field has logic or operator in if condition: conditional_struct { mask int32 f1 field1 (if[value[mask] & FIELD_FLAG1]) f2 int64 (if[value[mask] & FIELD_FLAG2]) f3 int64 (if[value[mask] == FIELD_FLAG1 || value[mask] == FIELD_FLAG2]) } [packed]
* all: follow new linter recommendationsTaras Madan2024-09-102-9/+9
|
* tools/syz-linter: check t.Logf/Errorf/Fatalf messagesDmitry Vyukov2024-04-171-1/+1
| | | | | Fix checking of Logf, it has string in 0-th arg. Add checking of t.Errorf/Fatalf.
* compiler: support using int flags in field conditionsPaul Chaignon2024-03-011-1/+4
| | | | | | | | | | | | | | | | | | | Commit ed571339c6ff ("pkg/compiler: support if[expr] attributes") added support for conditional fields in structs and unions. Conditions however cannot refer to flags, as in the following example: struct { f0 flags[some_flags, int32] f1 int32 (if[value[f0] & FLAG1]) } [packed] It will fail to compile with: flags does not refer to an integer This commit adds support for that syntax. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
* pkg/ast: support expressions with ast.TypeAleksandr Nogikh2024-02-199-22/+203
| | | | | | | | | | | | | | | | | | | | | So far they have the following grammar: OP = "==", "!=", "&" value-expr = value-expr OP value-expr | factor factor = "(" and-expr ")" | integer | identifier | string Operators are left associative, e.g. A & B & C is the same as (A & B) & C. Further restrictions will be imposed in pkg/compiler. This will help implement conditionally included fields.
* compiler: require nested flags to be at the end of the listPaul Chaignon2023-12-051-0/+9
| | | | | | | | | | | | | | | | | | | | | | | This commit adds the requirement that nested flags must be at the end of the list of values. For example, flags1 = 1, 2, 3, 4, flags2 flags2 cannot be moved to another position in the list. The goal is to simplify parsing of the list by humans. Enforcing that the nested flags be at the end (vs. the beginning) makes things a bit easier for the parser. If we enforced that they should be at the beginning, then the parser would need to look further forward to determine if a flags definition is an integer flags or a string flags. flags1 = flags2, flags3, flags4, 5, 6 In this example, the parser would need to look to the 4th value in the list to tell that it's an integer flags. Suggested-by: Aleksandr Nogikh <nogikh@google.com> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
* compiler: refactor recurFlattenFlagsPaul Chaignon2023-12-051-0/+33
| | | | | | | | | This commit refactors recurFlattenFlags using Go generics and new interfaces so that it also applies to a different set of flags types. In a subsequent commit, we will use that to perform the same recursive flattening for string flags. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
* ast: accept idents in string flagsPaul Chaignon2023-12-055-3/+11
| | | | | | | | | | | A subsequent commit will allow string flags to refer to other string flags (nested definitions). For that to happen, the parser must accept idents as part of the string flags definitions, as follows. strflags0 = "foo", strflags1 strflags1 = "bar" Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
* all: ioutil is deprecated in go1.19 (#3718)Taras Madan2023-02-233-7/+7
|
* pkg/ast, pkg/compiler: support per-file metadataDmitry Vyukov2022-04-297-2/+45
| | | | | | | | | | | | | | | | | | | | | We have a bunch of hacks in syz-extract, syz-sysgen and syz-check with respect to description files unsupported on some arches, or that must not be part of make extract. Add 2 meta attribtues to files: meta noextract Tells `make extract` to not extract constants for this file. Though, `syz-extract` can still be invoked manually on this file. meta arches["arch1", "arch2"] Restricts this file only to the given set of architectures. `make extract` and ``make generate` will not use it on other architectures. Later we can potentially use meta attributes to specify git tree/commit that must be used for extraction. Maybe something else. Fixes #2754
* pkg/ast: remove trailing spaces when formattingDmitry Vyukov2020-11-251-3/+4
|
* sys/targets: add OS/Arch name constsDmitry Vyukov2020-10-261-1/+3
| | | | | | | | | | | | We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere.
* pkg, prog: add per-field direction attributeNecip Fazil Yildiran2020-08-136-15/+44
|
* all: fix dup types in func argsDmitry Vyukov2020-07-041-1/+1
|
* .golangci.yml: make goconst checker more strictDmitry Vyukov2020-06-071-1/+1
|
* .golangci.yml: enable receiver name check for pkg/astDmitry Vyukov2020-06-071-38/+38
|
* .golangci.yml: enable godot checkerDmitry Vyukov2020-06-051-2/+2
| | | | | A good one. Lots of fixed comments are contributed by episodic contributors. So it's good to catch these earlier.
* pkg/ast: print full file name in errorsDmitry Vyukov2020-05-181-1/+1
| | | | | Print full names so that github annotations work. I.e. sys/linux/sys.txt instead of just sys.txt.
* pkg/ast: improve test outputDmitry Vyukov2020-05-052-12/+62
| | | | Improve the test utility to group error messages by line.
* pkg/ast: extend testsDmitry Vyukov2020-05-013-79/+114
| | | | Test more functions that we currently don't test.
* pkg/ast: add call attributesDmitry Vyukov2020-04-196-1/+26
|
* pkg/compiler: add tests for generation phaseDmitry Vyukov2020-03-172-7/+9
| | | | | | Add errors3.txt with tests for errors that are produced during generation phase. Refactor tests to reduce duplication. Tidy struct/union size errors: better locations and make testable.
* pkg/ast: introduce hex-encoded string literalsDmitry Vyukov2020-02-106-41/+70
| | | | | | | | | | | | | The stringnozescapes does not make sense with filename, also we may need similar escaping for string flags. Handle escaped strings on ast level instead. This avoids introducing new type and works seamleassly with flags. As alternative I've also tried using strconv.Quote/Unquote but it leads to ugly half-escaped strings: "\xb0\x80s\xe8\xd4N\x91\xe3ڒ,\"C\x82D\xbb\x88\\i\xe2i\xc8\xe9\xd85\xb1\x14):M\xdcn" Make hex-encoded strings a separate string format instead.
* pkg/ast: unexport Node.Walk()Paul Chaignon2019-10-232-20/+20
| | | | | | | Other packages should use ast.Recursive and ast.PostRecursive to ensure the root node is visited as well. Signed-off-by: Paul Chaignon <paul.chaignon@orange.com>
* pkg/compiler: fix infinite recursion in template instantiationDmitry Vyukov2019-10-101-1/+10
| | | | | | | | | Currently we replace a template argument and then recurse into the new type AST to see if there is more to replace. If the description is buggy and the template argument contains itself, then we will recurse infintiely trying to replace it more and more. Use post-order traversal when replacing template argument to fix this.
* pkg/ast: fix out-of-bounds accessDmitry Vyukov2019-07-301-1/+0
| | | | | Scanner can access data out of bounds on bad input. Also fix regression fuzz test to be able to detect the bug.
* pkg/compiler: support complex len targetsDmitry Vyukov2019-05-142-14/+17
| | | | | | | | | | This change adds compiler support for complex path expressions in len targets. E.g. it allows to refer to a sibling field as len[parent_struct:field:another_field]. See the docs change for details. This is just a compiler change. The feature is not yet supported by the prog package.
* pkg/ast: refactor COLON handlingDmitry Vyukov2019-05-145-23/+14
| | | | | | | This prepared for handling of bytesize[parent:foo:bar] expressions by allowing multiple identifiers after colon. No functional changes for now, just preparation for storing more than one identifier after colon.
* sys/linux: extend AX25/ROSE/NETROM descriptionsDmitry Vyukov2018-12-241-0/+1
|
* sys/fuchsia: prune unused structs in syscall description generated by fidlgenDokyung Song2018-09-111-0/+14
| | | | | | | | After generating syscall description for fidl files using fidlgen, prune all unused structs using the exact same mechanism used by the compiler's check for unused structs. This allows the FIDL compiler to support modular compilation; it does not need to have global knowledge of whether each struct is used or not.
* gometalinter: clean up vetshadowDmitry Vyukov2018-07-311-2/+2
| | | | | | | This just cleans up existing warnings. vetshadow is not enabled yet because it crashes. Update #538
* .gometalinter: reduce dupl thresholdDmitry Vyukov2018-07-311-40/+36
| | | | | | Reduce dupl threshold from 63 to 60 and fix violations. Update #538
* pkg/compiler: support negative integersDmitry Vyukov2018-07-096-47/+55
| | | | | | Currently we have to use 0xffffffffffffffff to represent -1, and we can't express e.g. -20:20 int range. Support negative consts to fix both problems.
* gometalinter: enable cyclomatic complexity checkingDmitry Vyukov2018-05-041-70/+93
| | | | | | Refactor some functions to be simpler. Update #538
* pkg/ast: support char constantsDmitry Vyukov2018-04-296-18/+49
| | | | | | | Frequently it's useful to do something like: int8['a':'z'] punctuation = ',', '-', ':'
* all: fix gometalinter warningsDmitry Vyukov2018-03-082-5/+5
| | | | Fix typos, non-canonical code, remove dead code, etc.
* pkg/compiler: switch attributes from Ident to TypeDmitry Vyukov2018-03-055-11/+16
| | | | | This allows parametrized attributes like size[10]. But this is not used for now.
* pkg/compiler: allow unions as syscall argumentsDmitry Vyukov2018-02-231-0/+6
| | | | | If all union options can be syscall arguments, allow the union itself as syscall argument.
* pkg/compiler: allow use of empty stringsDmitry Vyukov2018-01-236-13/+10
| | | | This comes up in several contexts in netfilter.
* pkg/compiler: support type templatesDmitry Vyukov2018-01-137-110/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Netlink descriptions contain tons of code duplication, and need much more for proper descriptions. Introduce type templates to simplify writing such descriptions and remove code duplication. Note: type templates are experimental, have poor error handling and are subject to change. Type templates can be declared as follows: ``` type buffer[DIR] ptr[DIR, array[int8]] type fileoff[BASE] BASE type nlattr[TYPE, PAYLOAD] { nla_len len[parent, int16] nla_type const[TYPE, int16] payload PAYLOAD } [align_4] ``` and later used as follows: ``` syscall(a buffer[in], b fileoff[int64], c ptr[in, nlattr[FOO, int32]]) ```
* pkg/ast: refactor WalkDmitry Vyukov2018-01-114-74/+98
| | | | | Refactor Walk so that it's possible to abort or wrap walk of child nodes. Will be needed for future changes.
* pkg/compiler: add builtin bool type aliasesDmitry Vyukov2018-01-081-2/+2
| | | | | | | | | | | | | | | | This adds builtin: type bool8 int8[0:1] type bool16 int16[0:1] type bool32 int32[0:1] type bool64 int64[0:1] type boolptr intptr[0:1] We used to use just int's for bools. But bool types provide several advantages: - make true/false probability equal - improve description expressiveness - reduce search space (we will take advantage of this later)
* sys: support type aliases (aka typedefs)Dmitry Vyukov2018-01-086-64/+107
| | | | | | | | | | | | | | | | | | | | | | Complex types that are often repeated can be given short type aliases using the following syntax: ``` type identifier underlying_type ``` For example: ``` type signalno int32[0:65] type net_port proc[20000, 4, int16be] ``` Then, type alias can be used instead of the underlying type in any contexts. Underlying type needs to be described as if it's a struct field, that is, with the base type if it's required. However, type alias can be used as syscall arguments as well. Underlying types are currently restricted to integer types, `ptr`, `ptr64`, `const`, `flags` and `proc` types.
* pkg/ast: fix TestParseAllDmitry Vyukov2017-10-191-10/+6
|
* executor, sys/windows: initial windows supportDmitry Vyukov2017-09-251-0/+3
|
generated by ggit (джигит) mrf-deployment (git 2.46.0) at 2026-03-11 19:26:58 +0000