aboutsummaryrefslogtreecommitdiffstats
path: root/executor
Commit message (Collapse)AuthorAgeFilesLines
* executor: fix format warningDmitry Vyukov2020-03-131-2/+2
|
* executor: fix data raceDmitry Vyukov2020-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ThreadSanitizer says: WARNING: ThreadSanitizer: data race (pid=3) Atomic read of size 4 at 0x56360e562f08 by main thread: #0 __tsan_atomic32_load <null> (libtsan.so.0+0x64249) #1 event_isset executor/common_linux.h:51 (syz-executor.0+0x2cf1f) #2 handle_completion executor/executor.cc:886 (syz-executor.0+0x2cf1f) #3 execute_one executor/executor.cc:732 (syz-executor.0+0x2da3b) #4 loop executor/common.h:581 (syz-executor.0+0x2f1aa) #5 do_sandbox_none executor/common_linux.h:2694 (syz-executor.0+0x189d6) #6 main executor/executor.cc:407 (syz-executor.0+0x189d6) Previous write of size 4 at 0x56360e562f08 by thread T1: #0 event_reset executor/common_linux.h:32 (syz-executor.0+0x1f5af) #1 worker_thread executor/executor.cc:1048 (syz-executor.0+0x1f5af) #2 <null> <null> (libtsan.so.0+0x2b0b6) Location is global 'threads' of size 2560 at 0x56360e562f00 (syz-executor.0+0x00000008bf08) Thread T1 (tid=6, running) created by main thread at: #0 pthread_create <null> (libtsan.so.0+0x2d55b) #1 thread_start executor/common.h:256 (syz-executor.0+0x2d707) #2 thread_create executor/executor.cc:1037 (syz-executor.0+0x2d707) #3 schedule_call executor/executor.cc:811 (syz-executor.0+0x2d707) #4 execute_one executor/executor.cc:719 (syz-executor.0+0x2d707) #5 loop executor/common.h:581 (syz-executor.0+0x2f1aa) #6 do_sandbox_none executor/common_linux.h:2694 (syz-executor.0+0x189d6) #7 main executor/executor.cc:407 (syz-executor.0+0x189d6)
* executor: add more debugging output for running=-1Dmitry Vyukov2020-03-131-1/+13
| | | | | | | | The running=-1 check fires periodically for the past 2 years. I can't reproduce nor understand how this happens. Add more debugging output, maybe it will shed some light. Update #502
* executor, sys/linux: add ath9k usb descriptionsAndrey Konovalov2020-03-136-39/+139
| | | | | | | Among other things this changes timeout for USB programs from 2 to 3 seconds. ath9k fuzzing also requires ath9k firmware to be present, so system images need to be regenerated with the updated script.
* executor: minor cleanup of android sandboxDmitry Vyukov2020-03-112-25/+22
| | | | Fix code formatting, clang-tidy warnings, minor style nits.
* executor: fix clang-tidy warningsDmitry Vyukov2020-03-113-4/+6
|
* executor: add seccomp support for Androidmspectorgoogle2020-03-116-20/+623
| | | | | | | | | | This adds support for the seccomp filters that are part of Android into the sandbox. A process running as untrusted_app in Android has a restricted set of syscalls that it is allow to run. This is accomplished by setting seccomp filters in the zygote process prior to forking into the application process. The seccomp filter list comes directly from the Android source, it cannot be dynamically loaded from an Android phone because libseccomp_policy.so does not exist as a library on the system partition.
* executor: prevent "NMI handler took too long" messagesDmitry Vyukov2020-03-062-0/+16
| | | | | | | | nmi_check_duration() prints "INFO: NMI handler took too long" on slow debug kernels. It happens a lot in qemu, and the messages are frequently corrupted (intermixed with other kernel output as they are printed from NMI) and are not matched against the suppression in pkg/report. This write prevents these messages from being printed.
* sys/openbsd: prevent killing the ssh VM connectionAnton Lindqvist2020-03-052-1/+2
| | | | | | | | | | This is one of the root causes of the 'no output from test machine' panic. Issuing a DIOCKILLSTATES ioctl on a /dev/pf file descriptor will cause state associated with ongoing connections to be purged; effectively killing the ssh connection to the VM. Including net/pfvar.h is necessary in order to make use of the DIOCKILLSTATES define.
* executor: don't exit if NETLINK_GENERIC isnt' supportedAndrei Vagin2020-02-271-2/+4
| | | | | | | NETLINK_GENERIC isn't supported in gVisor. Fixes: c5ed587f4af5 ("wireguard: setup some initial devices in a triangle") Signed-off-by: Andrei Vagin <avagin@google.com>
* executor: uncomment accidentially commented codeDmitry Vyukov2020-02-241-3/+3
| | | | | | | unshare(CLONE_NEWPID) was commented out in 4428511d10687cb446ad705148333478437d3f23 accidentially. Uncomment it. Spotted by @xairy: https://github.com/google/syzkaller/commit/4428511d10687cb446ad705148333478437d3f23#r37456572
* sys/linux: add NETLINK_SOCK_DIAG descriptionsDmitry Vyukov2020-02-212-6/+36
| | | | Incomplete, but something.
* sys/linux: add NETLINK_RDMA descriptionsDmitry Vyukov2020-02-213-15/+129
|
* sys/linux: add NETLINK_AUDIT descriptionsDmitry Vyukov2020-02-212-6/+102
|
* sys/linux: add smc_pnetid genetlink descriptionsDmitry Vyukov2020-02-202-6/+36
|
* sys/linux: add descriptions of wireguard packetsDmitry Vyukov2020-02-181-6/+6
|
* sys/linux: don't extract from futex.txt and watch_queue.txtDmitry Vyukov2020-02-182-6/+10
| | | | These are not present in linux-next.
* executor: disable IFF_NAPI_FRAGSDmitry Vyukov2020-02-181-1/+12
| | | | Update #1594
* sys/linux: add broadcast mac addressDmitry Vyukov2020-02-181-6/+6
| | | | | | | | | | | | | | | | | | | | | | Code in net/ethernet/eth.c does this: __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev) { ... if (unlikely(!ether_addr_equal_64bits(eth->h_dest, dev->dev_addr))) { if (unlikely(is_multicast_ether_addr_64bits(eth->h_dest))) { if (ether_addr_equal_64bits(eth->h_dest, dev->broadcast)) skb->pkt_type = PACKET_BROADCAST; else skb->pkt_type = PACKET_MULTICAST; } else { skb->pkt_type = PACKET_OTHERHOST; } } Multicast and broadcast are distinct and dev->broadcast seems to be ffffffffffff by default, so add another multicast mac address that will serve as PACKET_MULTICAST.
* executor: refactor extra cover handlingDmitry Vyukov2020-02-171-18/+16
| | | | | | | | | | | | | | | | | | | | | | | | | One observation is that checking for extra cover is very fast (effectively a memory load), so we can simplify code by removing th->extra_cover and just check for it always. Additionally, we may grab some coverage that we would miss otherwise. Don't sleep for 500 ms at the end if colliding, we are not going to use the extra coverage in that case anyway. Check for extra coverage at the end every 100ms to avoid being killed on timeout before we write any. Make the 500ms sleep at the end parametrizable. Enable it for syz_usb syscalls, so we get the same behavior for usb. But this also allows to get extra coverage for other subsystems. Some subsystems don't have a good way to detect if we will get any extra coverage or not. Sleeping for 500ms for all programs slows down fuzzing too much. So we check for extra coverage at the end for all programs (cheap anyway), but sleep only for usb program. This allows to collect extra coverage for vhost and maybe wireguard in future. Update #806
* sys/linux: add new FUTEX_WAIT_MULTIPLE operationAndré Almeida2020-02-172-6/+12
| | | | | | Create individual file for futex syscall and add description for the new operation FUTEX_WAIT_MULTIPLE. Signed-off-by: André Almeida <andrealmeid@collabora.com>
* sys/linux: add map batch operationsPaul Chaignon2020-02-162-5/+25
| | | | Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
* sys/linux: update BPF constants and structuresPaul Chaignon2020-02-161-6/+6
| | | | Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
* wireguard: setup some initial devices in a triangleJason A. Donenfeld2020-02-131-0/+272
| | | | | | | | | | | | | | | | | | | | | | | * wireguard: setup some initial devices in a triangle The fuzzer will wind up undoing some of this, which is fine, but at least it now has the chance of hitting some other paths it wasn't before. Closes: #1599 * wireguard: make code ugly after `make generate` pass * wireguard: get rid of unused structs that are still interesting * wireguard: compile in C++ mode with gcc 7 Complex designated initializers are only supported in C++ mode from gcc 8, and for whatever reason syzkaller wants to be compiled in C++ mode. * wireguard: add braces around debug statements for checker * wireguard: regenerate go source
* sys/linux: add SO_BINDTODEVICE specialization for wireguardDmitry Vyukov2020-02-122-6/+12
| | | | | | | SO_BINDTODEVICE for wg devices allows to reach very important part of functionality (wg_xmit). Update #806
* sys/linux: restrict wireguard allowedips cidr sizeJason A. Donenfeld2020-02-111-6/+6
| | | | By keeping this small, it means much greater probability that a randomly generated packet that hits xmit will match an existing peer.
* pkg/ast: introduce hex-encoded string literalsDmitry Vyukov2020-02-101-6/+6
| | | | | | | | | | | | | The stringnozescapes does not make sense with filename, also we may need similar escaping for string flags. Handle escaped strings on ast level instead. This avoids introducing new type and works seamleassly with flags. As alternative I've also tried using strconv.Quote/Unquote but it leads to ugly half-escaped strings: "\xb0\x80s\xe8\xd4N\x91\xe3ڒ,\"C\x82D\xbb\x88\\i\xe2i\xc8\xe9\xd85\xb1\x14):M\xdcn" Make hex-encoded strings a separate string format instead.
* sys/linux: dump netdev_addr_id for wg2Dmitry Vyukov2020-02-101-6/+6
| | | | | Commit "wireguard: use wg0, wg1, wg2" added wg2, bump netdev_addr_id accordingly.
* executor: increase input buffer sizeDmitry Vyukov2020-02-101-1/+1
| | | | | | | I bumped input buffer size on Go side in: a2af37f0 prog: increase encodingexec buffer size But I forgot to increase the size on the executor side. Do this and add comments re keeping them in sync.
* pkg/compiler: allow for escaped stringsJason A. Donenfeld2020-02-101-6/+6
| | | | | This adds stringnozescapes to allow parsing of escape sequences in strings.
* wireguard: use wg0, wg1, wg2Jason A. Donenfeld2020-02-102-10/+12
| | | | | This matches more closely what people are used to dealing with. We also add one additional device for interesting multi-interface effects.
* wireguard: increase chance that public and private will correspondJason A. Donenfeld2020-02-101-6/+6
| | | | | This tests more edge cases, as well as allowing for potentially a correponding public and private key to be installed.
* sys/linux: add new pidfd_getfd syscallChristian Brauner2020-02-062-6/+12
| | | | Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
* sys/linux: use literal consts instead of hardcoded numberDmitry Vyukov2020-02-011-6/+6
|
* sys/linux: add IPPROTO_MPTCP supportChristoph Paasch2020-02-012-6/+18
| | | | | Adding support for IPPROTO_MPTCP. Like SMC, it is on top of TCP and can thus be treated like a regular TCP socket.
* sys/linux: regenerate filesDmitry Vyukov2020-01-311-6/+6
|
* sys/linux: add some wireguard descriptionsDmitry Vyukov2020-01-313-6/+34
| | | | Update #806
* sys/linux: fix drm_mode_fb_cmd2 layoutDmitry Vyukov2020-01-281-6/+6
| | | | | | Thanks to syz-check for catching this. Update #590
* sys/linux: add ethtool netlink descriptionsDmitry Vyukov2020-01-282-6/+48
|
* sys/linux: add time namespace descriptionsDmitry Vyukov2020-01-271-6/+6
|
* prog: remove unused ResourceDesc.TypeDmitry Vyukov2020-01-261-15/+15
|
* pkg/serializer: do not write field names if it won't save spaceDmitry Vyukov2020-01-261-19/+19
| | | | | | | If we are going to write all values, don't write field names. This only increases size of generated files. The change reduces size of generated files by 5.8% (62870496-59410354=3460142 bytes saved).
* sys/linux: extend DRM ioctl descriptionsDmitry Vyukov2020-01-252-24/+224
| | | | | | + disable binderfs (see comments) + add few more missing tty ioctls + improve few minor things in hci descriptions
* sys/linux: restore FOU_ATTR_LOCAL/PEER_V6Dmitry Vyukov2020-01-231-6/+6
| | | | | They are being fixed in kernel: https://lists.openwall.net/netdev/2020/01/23/122
* sys/linux: improve infiniband_rdma descriptionsDmitry Vyukov2020-01-231-6/+6
|
* tools/syz-check: add limited checking of varlen structsDmitry Vyukov2020-01-231-6/+6
| | | | | | | | Stop at the fist varlen field, but check the preceeding ones. Frequently the varlen array is the last field, so we should get good checking for these cases. Update #590
* sys/linux: check for missing/duplicate netlink attrsDmitry Vyukov2020-01-231-6/+6
| | | | Update #590
* sys/linux: fix more netlink warningsDmitry Vyukov2020-01-231-6/+6
| | | | | | | | | | Handle NLA_BITFIELD32. Match string attribtues better. Calculate and check min size for varlen structs. Fix NLA_UNSPEC size check. Fix some things in descriptions. Update #590
* sys/linux: fix incorrect nlattr sizesDmitry Vyukov2020-01-221-6/+6
| | | | Update #590
* sys/linux: more fixing of netlink policy namesDmitry Vyukov2020-01-221-6/+6
| | | | Update #590