| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
| |
The test uses test names with spaces, testing package replaces spaces with _.
As the result, it's impossible to search for failed tests, and they all look
very similar. Replace space with _, so that it's possible to search for failed tests.
|
| |
|
|
|
|
|
| |
To make them accessible for non-admins, we need explicit checks in
access.go.
Extend TestAccess to cover fsck logs.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
The test has recently become broken, but we didn't notice it in our
presubmit testing.
Fix the problem (ReproLog being set to 0).
Run TestAccess also in -short mode, but limit it to ensuring that
non-public URLs are not accessible publicly. The short test now takes 60
seconds compared to 104 seconds without -short.
|
| |
|
|
|
| |
PR #4837 added displaying successfull repro logs to syzbot but didn't make
the logs publicly-accessible. Fix that.
|
| | |
|
| | |
|
| |
|
|
|
| |
Fix checking of Logf, it has string in 0-th arg.
Add checking of t.Errorf/Fatalf.
|
| |
|
|
| |
It contributes to #4285 unblocking.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to have a single global `config` variable and access it
throughout the whole dashboard application.
However, this approach has been more and more complicated test writing
-- sometimes we want the config to be only slightly different, so that
it's not worth it adding new namespaces, sometimes we have to test how
dashboard handles config changes over time.
This has already led to a number of hacky contextWithXXX methods that
mocked various parts of the global variable. The rest of the code had to
sometimes still use `config` directly and sometimes invoke getXXX(c)
methods. This is very inconsistent and prone to errors.
With more and more situations where we need to patch the config
appearing (see #4118), let's refactor the application to always access
config via the getConfig(c) method. This allows us to uniformly patch
the config and be sure that the non-patched copy is not accessible from
anywhere else.
|
| | |
|
| | |
|
| |
|
|
| |
Show graph pages to users who have access to the bugs themselves.
|
| |
|
|
|
|
| |
1. Updated the "include"s.
2. No logs read API in the AppEngine anymore. Replaced by the GCP logging API.
3. Use "GO111MODULE=off gcloud beta app deploy ./dashboard/app/app.yaml --no-promote" to test new deployment.
4. Updated the documentation.
|
| |
|
|
|
|
|
|
|
| |
Assorted local fixes fixes, like dedup machine info in the database,
fix up HTML table markup, enforce and check access to the machine info
entities, etc.
Follow up to #2085
Fixes #466
|
| |
|
|
| |
Checks for too long functions (based on lines and statements).
|
| |
|
|
|
|
|
|
|
|
| |
0. Remove aetest build tag. We don't need it anymore, go test should work.
1. IsDevAppServer does not return true in tests anymore, so don't use it
2. Use a different mechanism to register test/prod config.
We don't have aetest tag anymore, so we need something even more dynamic.
3. Fix new golangci-lint warnings: all test files are checked now.
Update #1461
|
| |
|
|
|
|
|
|
|
| |
The old go 1.9 App Engine runtime is now deprecated. Update to the go 1.11
runtime, which still allows us to use the old App Engine library (removed
in the 1.12 runtime).
Closes: #1461 ("dashboard: port app to go111/go112 runtime")
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
|
| |
|
|
|
|
|
|
| |
Currently it's not possible to list all invalid bugs.
Add a page that does this.
It's not referenced from anywhere as it's unclear who/when
needs it on periodic basis. But if the list is needed
for something one-off, we have it.
|
| |
|
|
|
|
|
| |
Login redirects broke because we failed to generate common header.
This wasn't noticed because we use client redirects
and there is no easy way to test them.
Fix redirects and use server redirect and test this behavior.
|
| |
|
|
|
|
|
| |
We now have too many namespaces and bugs.
Main page takes infinity to load.
Also almost nobody is interested in more than 1 namespace.
So split main page per-namespaces.
|
| |
|
|
|
|
| |
Use expectOK for checking errors more.
Use pollEmailBug helper more.
Add expectNE and use it.
|
| |
|
|
|
|
| |
We have some bugs with insane amount of repros.
So many that new crashes don't show up on dashboard at all.
Purge old repros too. There is no need to keep more than 40.
|
| |
|
|
|
|
|
|
|
|
| |
Allow a special case of cross-reporting duping:
rom last but one reporting to the last one (which is stable, final destination)
provided that these two reportings have the same access level and type.
The rest of the combinations can lead to surprising states and
information hiding, so we still don't allow them.
Fixes #569
|
| |
|
|
|
|
|
| |
Use standard dashboard client provided by dashapi package in tests.
Switch everything to use the client instead of API method.
Fixes #606
|
| |
|
|
|
|
|
|
|
| |
Align all info into nice table.
Shorten links a bit.
Remove some non-strictly-necessary info.
Rework some texts.
Fixes #565
|
| |
|
|
|
| |
Add a patched bug to the mix.
Check contents of crash logs/reports, kernel configs, etc.
|
|
|
This is the bulk of work for opening dashboard.
Implement finer-grained access control (admin/user/public).
Show only info designated to the current user access level.
Rework UIs for more clarity re bug statuses.
Show fixed bug.
|
