diff options
Diffstat (limited to 'tools/syz-linter')
| -rw-r--r-- | tools/syz-linter/linter.go | 6 | ||||
| -rw-r--r-- | tools/syz-linter/testdata/src/lintertest/lintertest.go | 9 |
2 files changed, 13 insertions, 2 deletions
diff --git a/tools/syz-linter/linter.go b/tools/syz-linter/linter.go index 542d040e6..14549aff4 100644 --- a/tools/syz-linter/linter.go +++ b/tools/syz-linter/linter.go @@ -301,14 +301,16 @@ func (pass *Pass) logFormatArg(n *ast.CallExpr) (arg int, newLine, sure bool) { break } return 1, true, true + case "t.Errorf", "t.Fatalf": + return 0, false, true } if fun.Sel.String() == "Logf" { - return 1, false, true + return 0, false, true } return -1, false, false } -var publicIdentifier = regexp.MustCompile(`^[A-Z][[:alnum:]]+(\.[[:alnum:]]+)+ `) +var publicIdentifier = regexp.MustCompile(`^[A-Z][[:alnum:]]+?((\.|[A-Z])[[:alnum:]]+)+ `) func stringLit(n ast.Node) (string, bool) { lit, ok := n.(*ast.BasicLit) diff --git a/tools/syz-linter/testdata/src/lintertest/lintertest.go b/tools/syz-linter/testdata/src/lintertest/lintertest.go index 51700726e..c6ba8ba8f 100644 --- a/tools/syz-linter/testdata/src/lintertest/lintertest.go +++ b/tools/syz-linter/testdata/src/lintertest/lintertest.go @@ -8,6 +8,7 @@ import ( "fmt" "log" "os" + "testing" ) /* some comment */ // want "Use C-style comments // instead of /* */" @@ -100,6 +101,14 @@ func logErrorMessages() { fmt.Fprintf(os.Stderr, "%v", err) // want "Add \\\\n at the end of printed messages" } +func testMessages(t *testing.T) { + t.Logf("good message %v", 1) + t.Logf("Bad message %v", 1) // want "Don't start log/error messages with a Capital letter" + t.Errorf("bad message %v\n", 1) // want "Don't use \\\\n at the end of log/error messages" + t.Fatalf("Bad message %v", 1) // want "Don't start log/error messages with a Capital letter" + t.Fatalf("PublicFunc is ok %v", 1) +} + func varDecls() { var a int b := 0 |