aboutsummaryrefslogtreecommitdiffstats
path: root/pkg
diff options
context:
space:
mode:
Diffstat (limited to 'pkg')
-rw-r--r--pkg/asset/storage_test.go12
-rw-r--r--pkg/ast/parser_test.go2
-rw-r--r--pkg/auth/auth_test.go16
-rw-r--r--pkg/build/linux_test.go2
-rw-r--r--pkg/compiler/compiler_test.go8
-rw-r--r--pkg/cover/backend/dwarf_test.go8
-rw-r--r--pkg/cover/cover_test.go2
-rw-r--r--pkg/csource/csource_test.go4
-rw-r--r--pkg/email/lore/parse_test.go2
-rw-r--r--pkg/ipc/ipc_priv_test.go2
-rw-r--r--pkg/ipc/ipc_test.go2
-rw-r--r--pkg/report/decompile_test.go2
-rw-r--r--pkg/report/linux_test.go10
-rw-r--r--pkg/report/report_test.go12
-rw-r--r--pkg/symbolizer/symbolizer_test.go4
-rw-r--r--pkg/vcs/vcs_test.go2
16 files changed, 45 insertions, 45 deletions
diff --git a/pkg/asset/storage_test.go b/pkg/asset/storage_test.go
index dcafdacf4..7500e9db3 100644
--- a/pkg/asset/storage_test.go
+++ b/pkg/asset/storage_test.go
@@ -184,14 +184,14 @@ func TestUploadBuildAsset(t *testing.T) {
be.objectRemove = func(string) error { return fmt.Errorf("not now") }
err = storage.DeprecateAssets()
if err == nil {
- t.Fatalf("DeprecateAssets() should have failed")
+ t.Fatalf("DeprecateAssets should have failed")
}
// Let the deletion be successful.
be.objectRemove = nil
err = storage.DeprecateAssets()
if err != nil {
- t.Fatalf("DeprecateAssets() was expected to be successful, got %s", err)
+ t.Fatalf("DeprecateAssets was expected to be successful, got %s", err)
}
path, err := be.getPath(allUrls[2])
if err != nil {
@@ -199,14 +199,14 @@ func TestUploadBuildAsset(t *testing.T) {
}
err = be.hasOnly([]string{path})
if err != nil {
- t.Fatalf("after first DeprecateAssets(): %s", err)
+ t.Fatalf("after first DeprecateAssets: %s", err)
}
// Delete the rest.
dashMock.downloadURLs = map[string]bool{}
err = storage.DeprecateAssets()
if err != nil || len(be.objects) != 0 {
- t.Fatalf("second DeprecateAssets() failed: %s, len %d",
+ t.Fatalf("second DeprecateAssets failed: %s, len %d",
err, len(be.objects))
}
}
@@ -365,7 +365,7 @@ func TestTwoBucketDeprecation(t *testing.T) {
url: true,
}
dummy.objectRemove = func(url string) error {
- t.Fatalf("Unexpected removal")
+ t.Fatalf("unexpected removal")
return nil
}
err := storage.DeprecateAssets()
@@ -389,7 +389,7 @@ func TestInvalidAssetURLs(t *testing.T) {
url: true,
}
dummy.objectRemove = func(url string) error {
- t.Fatalf("Unexpected removal")
+ t.Fatalf("unexpected removal")
return nil
}
err := storage.DeprecateAssets()
diff --git a/pkg/ast/parser_test.go b/pkg/ast/parser_test.go
index 5e25157f5..bc66ed4be 100644
--- a/pkg/ast/parser_test.go
+++ b/pkg/ast/parser_test.go
@@ -76,7 +76,7 @@ func TestParseAll(t *testing.T) {
desc4 := desc.Filter(func(n Node) bool { return true })
desc5 := desc.Filter(func(n Node) bool { return false })
if len(desc4.Nodes) != len(desc.Nodes) || len(desc5.Nodes) != 0 {
- t.Fatalf("Filter is broken: desc=%v desc4=%v desc5=%v",
+ t.Fatalf("filter is broken: desc=%v desc4=%v desc5=%v",
len(desc.Nodes), len(desc4.Nodes), len(desc5.Nodes))
}
})
diff --git a/pkg/auth/auth_test.go b/pkg/auth/auth_test.go
index d343e0f33..1c317fe15 100644
--- a/pkg/auth/auth_test.go
+++ b/pkg/auth/auth_test.go
@@ -21,7 +21,7 @@ func reponseFor(t *testing.T, claims jwtClaims) (*httptest.Server, Endpoint) {
Expiration: fmt.Sprint(claims.Expiration.Unix()),
})
if err != nil {
- t.Fatalf("Marshal %v", err)
+ t.Fatalf("marshal %v", err)
}
w.Header()["Content-Type"] = []string{"application/json"}
w.Write(bytes)
@@ -41,10 +41,10 @@ func TestBearerValid(t *testing.T) {
got, err := dut.DetermineAuthSubj(tm, []string{"Bearer x"})
if err != nil {
- t.Errorf("Unexpected error %v", err)
+ t.Errorf("inexpected error %v", err)
}
if !strings.HasSuffix(got, magic) {
- t.Errorf("Wrong subj %v not suffix of %v", magic, got)
+ t.Errorf("wrong subj %v not suffix of %v", magic, got)
}
}
@@ -59,7 +59,7 @@ func TestBearerWrongAudience(t *testing.T) {
_, err := dut.DetermineAuthSubj(tm, []string{"Bearer x"})
if !strings.HasPrefix(err.Error(), "unexpected audience") {
- t.Fatalf("Unexpected error %v", err)
+ t.Fatalf("unexpected error %v", err)
}
}
@@ -74,7 +74,7 @@ func TestBearerExpired(t *testing.T) {
_, err := dut.DetermineAuthSubj(tm, []string{"Bearer x"})
if !strings.HasPrefix(err.Error(), "token past expiration") {
- t.Fatalf("Unexpected error %v", err)
+ t.Fatalf("unexpected error %v", err)
}
}
@@ -83,7 +83,7 @@ func TestMissingHeader(t *testing.T) {
defer ts.Close()
got, err := dut.DetermineAuthSubj(time.Now(), []string{})
if err != nil || got != "" {
- t.Errorf("Unexpected error %v %v", got, err)
+ t.Errorf("unexpected error %v %v", got, err)
}
}
@@ -92,7 +92,7 @@ func TestBadHeader(t *testing.T) {
defer ts.Close()
got, err := dut.DetermineAuthSubj(time.Now(), []string{"bad"})
if err != nil || got != "" {
- t.Errorf("Unexpected error %v %v", got, err)
+ t.Errorf("unexpected error %v %v", got, err)
}
}
@@ -104,6 +104,6 @@ func TestBadHttpStatus(t *testing.T) {
dut := MakeEndpoint(ts.URL)
got, err := dut.DetermineAuthSubj(time.Now(), []string{"Bearer x"})
if err == nil || !strings.HasSuffix(err.Error(), "400") || got != "" {
- t.Errorf("Unexpected error %v %v", got, err)
+ t.Errorf("unexpected error %v %v", got, err)
}
}
diff --git a/pkg/build/linux_test.go b/pkg/build/linux_test.go
index 31fbdceaa..91d344531 100644
--- a/pkg/build/linux_test.go
+++ b/pkg/build/linux_test.go
@@ -38,7 +38,7 @@ func TestQueryLinuxCompiler(t *testing.T) {
const badDir = "./testingData/non_existing_folder"
_, err = queryLinuxCompiler(badDir)
if err == nil {
- t.Fatalf("Expected an error, got none")
+ t.Fatalf("expected an error, got none")
}
}
diff --git a/pkg/compiler/compiler_test.go b/pkg/compiler/compiler_test.go
index dbb4d6582..0a2396b5b 100644
--- a/pkg/compiler/compiler_test.go
+++ b/pkg/compiler/compiler_test.go
@@ -281,16 +281,16 @@ func TestCollectUnused(t *testing.T) {
for i, input := range inputs {
desc := ast.Parse([]byte(input.text), "input", nil)
if desc == nil {
- t.Fatalf("Test %d: failed to parse", i)
+ t.Fatalf("test %d: failed to parse", i)
}
nodes, err := CollectUnused(desc, targets.List[targets.TestOS][targets.TestArch64], nil)
if err != nil {
- t.Fatalf("Test %d: CollectUnused failed: %v", i, err)
+ t.Fatalf("test %d: CollectUnused failed: %v", i, err)
}
if len(input.names) != len(nodes) {
- t.Errorf("Test %d: want %d nodes, got %d", i, len(input.names), len(nodes))
+ t.Errorf("test %d: want %d nodes, got %d", i, len(input.names), len(nodes))
}
names := make([]string, len(nodes))
@@ -302,7 +302,7 @@ func TestCollectUnused(t *testing.T) {
sort.Strings(input.names)
if !reflect.DeepEqual(names, input.names) {
- t.Errorf("Test %d: Unused nodes differ. Want %v, Got %v", i, input.names, names)
+ t.Errorf("test %d: Unused nodes differ. Want %v, Got %v", i, input.names, names)
}
}
}
diff --git a/pkg/cover/backend/dwarf_test.go b/pkg/cover/backend/dwarf_test.go
index 9d4da8e90..d95c1ec01 100644
--- a/pkg/cover/backend/dwarf_test.go
+++ b/pkg/cover/backend/dwarf_test.go
@@ -27,12 +27,12 @@ func TestIsKcovBrokenInCompiler(t *testing.T) {
}
for _, ver := range inputDataTrue {
if !isKcovBrokenInCompiler(ver) {
- t.Fatalf("isKcovBrokenInCompiler(%q) unexpectedly returned false\n", ver)
+ t.Fatalf("isKcovBrokenInCompiler(%q) unexpectedly returned false", ver)
}
}
for _, ver := range inputDataFalse {
if isKcovBrokenInCompiler(ver) {
- t.Fatalf("isKcovBrokenInCompiler(%q) unexpectedly returned true\n", ver)
+ t.Fatalf("isKcovBrokenInCompiler(%q) unexpectedly returned true", ver)
}
}
}
@@ -94,7 +94,7 @@ func TestCleanPathAndroid(t *testing.T) {
path, epath, ename := files[0], files[1], files[2]
rpath, rname := cleanPathAndroid(path, test.SrcDir, test.Delimiters, test.FnExists)
if (rpath != epath) || (rname != ename) {
- t.Fatalf("cleanPathAndroid(`%s`, `%s`, %v, ...) unexpectedly returned (`%s`, `%s`) instead of (`%s`, `%s`)\n",
+ t.Fatalf("cleanPathAndroid(`%s`, `%s`, %v, ...) unexpectedly returned (`%s`, `%s`) instead of (`%s`, `%s`)",
path, test.SrcDir, test.Delimiters, rpath, rname, epath, ename)
}
}
@@ -113,7 +113,7 @@ func runNextCallTarget(t *testing.T, arg NextCallTargetTest) {
i := 0
target, pc := nextCallTarget(arg.Arch, arg.Text, arg.Data, &i)
if target != arg.ExpTarget || pc != arg.ExpPC {
- t.Fatalf("nextCallTarget(`%v`, %x, %v) unexpectedly returned (%x, %x) instead of (%x, %x)\n",
+ t.Fatalf("nextCallTarget(`%v`, %x, %v) unexpectedly returned (%x, %x) instead of (%x, %x)",
arg.Arch, arg.Text, arg.Data, target, pc, arg.ExpTarget, arg.ExpPC)
}
}
diff --git a/pkg/cover/cover_test.go b/pkg/cover/cover_test.go
index 2124fb3c8..d5f214ff5 100644
--- a/pkg/cover/cover_test.go
+++ b/pkg/cover/cover_test.go
@@ -51,7 +51,7 @@ func TestMergeDiff(t *testing.T) {
cov.Merge(test.init)
diff := cov.MergeDiff(test.merge)
if res := cmp.Diff(test.diff, diff); res != "" {
- t.Fatalf("MergeDiff result is wrong: %v", res)
+ t.Fatalf("result is wrong: %v", res)
}
result := cov.Serialize()
sort.Slice(result, func(i, j int) bool {
diff --git a/pkg/csource/csource_test.go b/pkg/csource/csource_test.go
index 957d2ebc9..8b4d83296 100644
--- a/pkg/csource/csource_test.go
+++ b/pkg/csource/csource_test.go
@@ -139,7 +139,7 @@ func testOne(t *testing.T, p *prog.Prog, opts Options) {
if atomic.AddUint32(&failedTests, 1) > maxFailures {
t.Fatal()
}
- t.Logf("opts: %+v\nprogram:\n%s\n", opts, p.Serialize())
+ t.Logf("opts: %+v\nprogram:\n%s", opts, p.Serialize())
t.Fatalf("%v", err)
}
bin, err := Build(p.Target, src)
@@ -147,7 +147,7 @@ func testOne(t *testing.T, p *prog.Prog, opts Options) {
if atomic.AddUint32(&failedTests, 1) > maxFailures {
t.Fatal()
}
- t.Logf("opts: %+v\nprogram:\n%s\n", opts, p.Serialize())
+ t.Logf("opts: %+v\nprogram:\n%s", opts, p.Serialize())
t.Fatalf("%v", err)
}
defer os.Remove(bin)
diff --git a/pkg/email/lore/parse_test.go b/pkg/email/lore/parse_test.go
index 13370045c..8349859ec 100644
--- a/pkg/email/lore/parse_test.go
+++ b/pkg/email/lore/parse_test.go
@@ -238,7 +238,7 @@ Bug report`,
}
if len(threads) > len(expected) {
- t.Fatalf("Expected %d threads, got %d", len(expected), len(threads))
+ t.Fatalf("expected %d threads, got %d", len(expected), len(threads))
}
}
diff --git a/pkg/ipc/ipc_priv_test.go b/pkg/ipc/ipc_priv_test.go
index be164911a..054916045 100644
--- a/pkg/ipc/ipc_priv_test.go
+++ b/pkg/ipc/ipc_priv_test.go
@@ -20,6 +20,6 @@ func TestOutputDeadline(t *testing.T) {
c.wait()
out := <-c.readDone
if string(out) != "done\n" {
- t.Errorf("Unexpected output: '%s'", out)
+ t.Errorf("unexpected output: '%s'", out)
}
}
diff --git a/pkg/ipc/ipc_test.go b/pkg/ipc/ipc_test.go
index 859e14948..ffb28d0a6 100644
--- a/pkg/ipc/ipc_test.go
+++ b/pkg/ipc/ipc_test.go
@@ -94,7 +94,7 @@ func TestExecute(t *testing.T) {
flags := []ExecFlags{0, FlagThreaded}
for _, flag := range flags {
- t.Logf("testing flags 0x%x\n", flag)
+ t.Logf("testing flags 0x%x", flag)
cfg := &Config{
Executor: bin,
UseShmem: useShmem,
diff --git a/pkg/report/decompile_test.go b/pkg/report/decompile_test.go
index c89b88681..7e05561af 100644
--- a/pkg/report/decompile_test.go
+++ b/pkg/report/decompile_test.go
@@ -52,6 +52,6 @@ Disassembly of section .data:
},
}
if !reflect.DeepEqual(opcodes, expected) {
- t.Errorf("Expected: %#v, got: %#v", expected, opcodes)
+ t.Errorf("expected: %#v, got: %#v", expected, opcodes)
}
}
diff --git a/pkg/report/linux_test.go b/pkg/report/linux_test.go
index 5f27b9e7d..258efb271 100644
--- a/pkg/report/linux_test.go
+++ b/pkg/report/linux_test.go
@@ -248,7 +248,7 @@ func prepareLinuxReporter(t *testing.T, arch string) (*Reporter, *linux) {
}
reporter, err := NewReporter(cfg)
if err != nil {
- t.Errorf("Failed to create a reporter instance for %#v: %v", arch, err)
+ t.Errorf("failed to create a reporter instance for %#v: %v", arch, err)
}
return reporter, reporter.impl.(*linux)
}
@@ -369,11 +369,11 @@ func TestParseLinuxOpcodes(t *testing.T) {
_, linuxReporter := prepareLinuxReporter(t, test.arch)
ret, err := linuxReporter.parseOpcodes(test.input)
if test.output == nil && err == nil {
- t.Errorf("Expected an error on input %#v", test)
+ t.Errorf("expected an error on input %#v", test)
} else if test.output != nil && err != nil {
- t.Errorf("Unexpected error %v on input %#v", err, test.input)
+ t.Errorf("unexpected error %v on input %#v", err, test.input)
} else if test.output != nil && !reflect.DeepEqual(ret, *test.output) {
- t.Errorf("Expected: %#v, got: %#v", test.output, ret)
+ t.Errorf("expected: %#v, got: %#v", test.output, ret)
}
})
}
@@ -441,6 +441,6 @@ func testDisassembly(t *testing.T, reporter *Reporter, linuxReporter *linux, tes
}
if !bytes.Equal(output, result) {
- t.Fatalf("Expected:\n%s\nGot:\n%s\n", output, result)
+ t.Fatalf("expected:\n%s\ngot:\n%s", output, result)
}
}
diff --git a/pkg/report/report_test.go b/pkg/report/report_test.go
index 934d4552e..9671607ec 100644
--- a/pkg/report/report_test.go
+++ b/pkg/report/report_test.go
@@ -148,10 +148,10 @@ func testParseImpl(t *testing.T, reporter *Reporter, test *ParseTest) {
containsCrash := reporter.ContainsCrash(test.Log)
expectCrash := (test.Title != "")
if expectCrash && !containsCrash {
- t.Fatalf("ContainsCrash did not find crash")
+ t.Fatalf("did not find crash")
}
if !expectCrash && containsCrash {
- t.Fatalf("ContainsCrash found unexpected crash")
+ t.Fatalf("found unexpected crash")
}
if rep != nil && rep.Title == "" {
t.Fatalf("found crash, but title is empty")
@@ -185,7 +185,7 @@ func testParseImpl(t *testing.T, reporter *Reporter, test *ParseTest) {
wantAltTitles += "ALT: " + t + "\n"
}
t.Fatalf("want:\nTITLE: %s\n%sTYPE: %v\nFRAME: %v\nCORRUPTED: %v\nSUPPRESSED: %v\n"+
- "got:\nTITLE: %s\n%sTYPE: %v\nFRAME: %v\nCORRUPTED: %v (%v)\nSUPPRESSED: %v\n",
+ "got:\nTITLE: %s\n%sTYPE: %v\nFRAME: %v\nCORRUPTED: %v (%v)\nSUPPRESSED: %v",
test.Title, wantAltTitles, test.Type, test.Frame, test.Corrupted, test.Suppressed,
title, gotAltTitles, typ, frame, corrupted, corruptedReason, suppressed)
}
@@ -206,13 +206,13 @@ func checkReport(t *testing.T, reporter *Reporter, rep *Report, test *ParseTest)
t.Fatalf("bad Output:\n%s", rep.Output)
}
if rep.StartPos != 0 && rep.EndPos != 0 && rep.StartPos >= rep.EndPos {
- t.Fatalf("StartPos=%v >= EndPos=%v", rep.StartPos, rep.EndPos)
+ t.Fatalf("StartPos %v >= EndPos %v", rep.StartPos, rep.EndPos)
}
if rep.EndPos > len(rep.Output) {
- t.Fatalf("EndPos=%v > len(Output)=%v", rep.EndPos, len(rep.Output))
+ t.Fatalf("EndPos %v > len(Output) %v", rep.EndPos, len(rep.Output))
}
if rep.SkipPos <= rep.StartPos || rep.SkipPos > rep.EndPos {
- t.Fatalf("bad SkipPos=%v: StartPos=%v EndPos=%v", rep.SkipPos, rep.StartPos, rep.EndPos)
+ t.Fatalf("bad SkipPos %v: StartPos %v EndPos %v", rep.SkipPos, rep.StartPos, rep.EndPos)
}
if test.StartLine != "" {
if test.EndLine == "" {
diff --git a/pkg/symbolizer/symbolizer_test.go b/pkg/symbolizer/symbolizer_test.go
index d7e996bb0..f6445367e 100644
--- a/pkg/symbolizer/symbolizer_test.go
+++ b/pkg/symbolizer/symbolizer_test.go
@@ -159,7 +159,7 @@ func TestParse(t *testing.T) {
t.Fatalf("got error: %v", err)
}
if !reflect.DeepEqual(addr.frames, frames) {
- t.Fatalf("want frames:\n%+v\ngot:\n%+v\n", addr.frames, frames)
+ t.Fatalf("want frames:\n%+v\ngot:\n%+v", addr.frames, frames)
}
allPCs = append(allPCs, addr.pc)
allFrames = append(allFrames, frames...)
@@ -177,7 +177,7 @@ func TestParse(t *testing.T) {
}
frames = append(frames, frames2...)
if !reflect.DeepEqual(allFrames, frames) {
- t.Fatalf("want frames:\n%+v\ngot:\n%+v\n", allFrames, frames)
+ t.Fatalf("want frames:\n%+v\ngot:\n%+v", allFrames, frames)
}
}
diff --git a/pkg/vcs/vcs_test.go b/pkg/vcs/vcs_test.go
index aeccb3149..01e1fe7f5 100644
--- a/pkg/vcs/vcs_test.go
+++ b/pkg/vcs/vcs_test.go
@@ -226,7 +226,7 @@ func TestFileLink(t *testing.T) {
for _, test := range tests {
link := FileLink(test.URL, test.Hash, test.File, test.Line)
if link != test.FileLink {
- t.Errorf("Test: %+v\ngot: %v", test, link)
+ t.Errorf("test: %+v\ngot: %v", test, link)
}
}
}
generated by ggit (джигит) mrf-deployment (git 2.46.0) at 2026-03-11 22:03:15 +0000