diff options
Diffstat (limited to 'pkg/validator')
| -rw-r--r-- | pkg/validator/validator.go | 3 | ||||
| -rw-r--r-- | pkg/validator/validator_test.go | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/pkg/validator/validator.go b/pkg/validator/validator.go index 723cf2384..d4192f7b6 100644 --- a/pkg/validator/validator.go +++ b/pkg/validator/validator.go @@ -66,6 +66,9 @@ type strValidationFunc func(string, ...string) Result func makeStrReFunc(errStr, reStr string) strValidationFunc { matchRe := regexp.MustCompile(reStr) return func(s string, objName ...string) Result { + if s == "" { + return Result{false, wrapError(errStr + ": can't be empty")} + } if !matchRe.MatchString(s) { return Result{false, wrapError(errStr, objName...)} } diff --git a/pkg/validator/validator_test.go b/pkg/validator/validator_test.go index ef04d9cde..6397081e4 100644 --- a/pkg/validator/validator_test.go +++ b/pkg/validator/validator_test.go @@ -24,6 +24,7 @@ func TestIsCommitHash(t *testing.T) { validator.CommitHash("!311c1b497e51a628aa89e7cb954481e5f9dced2", "valName").Err.Error()) } +// nolint: dupl func TestIsNamespaceName(t *testing.T) { assert.True(t, validator.NamespaceName("upstream").Ok) assert.False(t, validator.NamespaceName("up").Ok) @@ -58,6 +59,7 @@ func TestIsDashboardClientKey(t *testing.T) { func TestIsKernelFilePath(t *testing.T) { assert.True(t, validator.KernelFilePath("io_uring/advise.c").Ok) assert.False(t, validator.KernelFilePath("io-uring/advise.c").Ok) + assert.False(t, validator.KernelFilePath("").Ok) assert.Equal(t, "not a kernel file path", validator.KernelFilePath("io-uring").Err.Error()) assert.Equal(t, "kernelPath: not a kernel file path", |