diff options
| -rw-r--r-- | dashboard/app/api.go | 4 | ||||
| -rw-r--r-- | pkg/email/parser.go | 2 | ||||
| -rw-r--r-- | pkg/runtest/run.go | 2 | ||||
| -rw-r--r-- | vm/proxyapp/proxyappclient.go | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/dashboard/app/api.go b/dashboard/app/api.go index f7f139f86..82b90fed8 100644 --- a/dashboard/app/api.go +++ b/dashboard/app/api.go @@ -563,8 +563,8 @@ func addCommitsToBugsInStatus(c context.Context, status int, ns, manager string, return nil } -func addCommitsToBug(c context.Context, bug *Bug, manager string, managers []string, - fixCommits []string, presentCommits map[string]bool) error { +func addCommitsToBug(c context.Context, bug *Bug, manager string, managers, fixCommits []string, + presentCommits map[string]bool) error { if !bugNeedsCommitUpdate(c, bug, manager, fixCommits, presentCommits, true) { return nil } diff --git a/pkg/email/parser.go b/pkg/email/parser.go index 6974f66d5..e2d3d0ab8 100644 --- a/pkg/email/parser.go +++ b/pkg/email/parser.go @@ -64,7 +64,7 @@ func prepareEmails(list []string) map[string]bool { return ret } -func Parse(r io.Reader, ownEmails []string, goodLists []string) (*Email, error) { +func Parse(r io.Reader, ownEmails, goodLists []string) (*Email, error) { msg, err := mail.ReadMessage(r) if err != nil { return nil, fmt.Errorf("failed to read email: %v", err) diff --git a/pkg/runtest/run.go b/pkg/runtest/run.go index f8ef5cb86..d58f148cb 100644 --- a/pkg/runtest/run.go +++ b/pkg/runtest/run.go @@ -378,7 +378,7 @@ func (ctx *Context) produceTest(progs chan *RunRequest, req *RunRequest, name st progs <- req } -func match(props map[string]bool, requires map[string]bool) bool { +func match(props, requires map[string]bool) bool { for req, positive := range requires { if positive { if !props[req] { diff --git a/vm/proxyapp/proxyappclient.go b/vm/proxyapp/proxyappclient.go index 733673d5f..1104d1901 100644 --- a/vm/proxyapp/proxyappclient.go +++ b/vm/proxyapp/proxyappclient.go @@ -256,7 +256,7 @@ func (proxy *ProxyApp) signalLostConnection() { } } -func (proxy *ProxyApp) Call(serviceMethod string, args interface{}, reply interface{}) error { +func (proxy *ProxyApp) Call(serviceMethod string, args, reply interface{}) error { err := proxy.Client.Call(serviceMethod, args, reply) if err == rpc.ErrShutdown { proxy.signalLostConnection() |