aboutsummaryrefslogtreecommitdiffstats
path: root/vm
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2016-09-09 13:22:48 +0200
committerDmitry Vyukov <dvyukov@google.com>2016-09-09 13:22:48 +0200
commitd87ae1c44494700f681d7d50efec8d5500716c33 (patch)
treee3c520fdcac6f7c1f87fef64f73b77fb132cc827 /vm
parent824b2687cfab5f95ab29f84474811a84d6442644 (diff)
manager: fix deadlock
This fixes 2 problems: 1. syz-manager inverted condition for local instances. 2. local instances deadlocked on "no output" condition
Diffstat (limited to 'vm')
-rw-r--r--vm/vm.go5
1 files changed, 4 insertions, 1 deletions
diff --git a/vm/vm.go b/vm/vm.go
index 25d5010da..ac60c8de0 100644
--- a/vm/vm.go
+++ b/vm/vm.go
@@ -107,10 +107,12 @@ func MonitorExecution(outc <-chan []byte, errc <-chan error, local, needOutput b
)
lastExecuteTime := time.Now()
ticker := time.NewTimer(3 * time.Minute)
+ tickerFired := false
for {
- if !ticker.Stop() {
+ if !tickerFired && !ticker.Stop() {
<-ticker.C
}
+ tickerFired = false
ticker.Reset(3 * time.Minute)
select {
case err := <-errc:
@@ -160,6 +162,7 @@ func MonitorExecution(outc <-chan []byte, errc <-chan error, local, needOutput b
return "test machine is not executing programs", nil, output, true, false
}
case <-ticker.C:
+ tickerFired = true
if !local {
return "no output from test machine", nil, output, true, false
}